Imperative transaction ordering#47
Draft
davidrobinson05 wants to merge 4 commits into
Draft
Conversation
Contributor
|
Can we move the cycle check out off the commit? It is a expensive method (including 2 java,util.HashSet inits) to run each time when a commit happens. |
Contributor
|
Why is 'imperativeTransactions = imperativeTransactions.putEdge(SOURCE, TARGET, Void.class);' in commit()? |
Contributor
|
I think I rather have one atomic Reference per Imperative transaction. You can then set it status for a certain commit run (number). You can avoid to initialize 3 atomic references per commit and keep track of the inCync in a relative manner. Hope this makes sence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #38
Depends on ModelingValueGroup/immutable-collections#42