Optimize asymmetric 2-bit zero-point search - #3013
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
An affine 2-bit grid has four codes. With zero point 2 its reconstructed levels are proportional to
[-2, -1, 0, 1]; with zero point 1 they are proportional to[-1, 0, 1, 2].The existing range search rounded the ideal affine zero point before measuring reconstruction error. At two bits, that rounding decision chooses which side receives the fourth level, so range geometry could select the orientation independently of the MSE objective.
For each scale candidate, this change retains the rounded zero point and also evaluates the other adjacent legal integer zero point. The previous candidate remains in the search set, so the selected local objective cannot become worse.
Scope
The additional candidate is restricted to
bits=2,sym=False, non-groupwise affine quantization when MSE range search is enabled. Symmetric quantization, other bit widths, groupwise signed quantization, configuration, packing, and serialized formats are unchanged.Validation
pytest -q tests/test_gptq.py: 3 passed, 4 accelerator-only tests skippedE9,F63,F7,F82) passed on changed filesgit diff --checkpassed