Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
models.autofrom globally forcingPYTORCH_ENABLE_MPS_FALLBACK=1on macOSWhy
Modern PyTorch MPS implements the GPTQ Hessian and quantization operations used here. The old guard forced unsupported operations onto CPU even when the Metal implementation was available, preventing native MPS execution and making Hessian math substantially slower on Apple Silicon.
Fallback remains available as an explicit PyTorch opt-in for users running older builds with unsupported operations.
Validation
tests/test_mps_gptq.py: 2 passed on Apple M4 Max withPYTORCH_ENABLE_MPS_FALLBACKunsetgit diff --check