harden free-threaded lock ownership - #3009
Merged
Merged
Conversation
Qubitium
marked this pull request as ready for review
August 7, 2026 03:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseExceptionWhy
Several fallback paths dynamically created locks during ordinary API calls or allocated a temporary lock on every workspace lease. That adds overhead and makes free-threaded ownership harder to reason about. Worker collection also used an exception allow-list, allowing a custom
BaseExceptionsubclass to bypass the drain guarantee while other workers could still be using shared subset state.The locks remain access-scoped or key-scoped. Worker tasks are still submitted before result collection, so module processing remains parallel.
Validation
setdefault(..., Lock())factories