fix looper concurrency safety - #3008
Merged
Merged
Conversation
Qubitium
marked this pull request as ready for review
August 6, 2026 13:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Parallel quantization workers can access processor-owned state while the orchestration thread updates or clears it. In addition, result collection previously stopped at the first failed future, allowing later submitted workers to remain active while the subset stage unwound.
Impact
Worker failures no longer leave sibling quantization work running during stage teardown. Shared looper state is protected for parallel and free-threaded execution. This does not change quantization math, checkpoint formats, or user configuration.
Validation
python -m pytest -q tests/test_looper_concurrency.py tests/test_weight_only_looper.py tests/test_moe_expert_batching.py— 25 passed under Python 3.14t with the GIL disabledgit diff --checkpassed