fix(compiler): bound instant-binary cache retention - #192
Merged
Merged
Conversation
The per-hash binaries store written by ArduinoCompiler was never an LRU target, so it grew without bound. Add it to the worker eviction targets and the main-thread cleanup, and drop the .output.txt sidecar together with an evicted HEX entry. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified against origin/main 6c284fb:
<buildCacheDir>/binaries(+.output.txtsidecars) was written per sketch hash but never evicted; main-thread cleanup also left sidecars of evicted HEX files.buildCacheEvictionTargets)RED/GREEN: new cache-manager sidecar test fails without the fix. No API/SSOT changes.
🤖 Generated with Claude Code