fix(simulation): invalidate obsolete REST compile-to-start ownership - #190
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction and scope
Base: freshly fetched
5b425872cc90fc23c617a4792fdc06146db5b417, after green post-merge CI for #189.Real React Query/controller hooks with deferred HTTP responses reproduced nine main regressions. React Query already prevents obsolete per-call success callbacks and post-unmount starts; shared mutation callbacks still let an old failure stop a newer run. These callbacks now obey the same ownership guard.
Independent review found cancellation could leave compile indicators busy without a WebSocket terminal response. Three additional RED/GREEN cases cover offline cancellation, external replacement and cancellation before the mutation body runs. Standalone Compile supersession has another RED/GREEN test. Focused suites: 67 passed.
Ordinary editor edits and same-project tab navigation retain the captured-source behavior. Context cancellation is explicit at existing replacement/load boundaries and tracks workspace identity, avoiding a new editor or Tutor policy. No HTTP/WebSocket payload or external API contract changes; no SSOT/ADR/Tutor/Planner/Mastery/Prompt changes or Provider calls.
Verification