fix(process): isolate execution ownership and bound output - #187
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction and review
Base: freshly fetched origin/main
221b83b9b248ab524c299ffe0e7ac890f23d7dccafter successful post-merge CI for #186.Deterministic RED/GREEN regressions cover a sibling's lost timeout, lost busy/kill ownership, detached process groups, pending pre-spawn stop, combined output overflow, exact boundaries, UTF-8 byte counting, bounded diagnostic prefix, late output and invalid budgets.
An independent reviewer reproduced the pre-spawn stop race with real echo; its fix is covered by an additional RED/GREEN regression. No other important findings.
Limit scope: the budget counts raw captured/forwarded bytes. A truncated UTF-8 sequence may render as a replacement character in diagnostics; changing the existing decoding semantics is deferred. Callback reentrancy and broader LocalCompiler filesystem/retry cancellation are outside this executor patch.
Verification
No Provider calls, SSOT/ADR changes, Tutor/Planner/Mastery/Prompt changes, or changes to existing protected/untracked local documents.