Skip to content

Fix dark mode styling regressions#6354

Closed
SeniorZhai wants to merge 2 commits into
masterfrom
fix/dark-mode
Closed

Fix dark mode styling regressions#6354
SeniorZhai wants to merge 2 commits into
masterfrom
fix/dark-mode

Conversation

@SeniorZhai

Copy link
Copy Markdown
Member

No description provided.

@SeniorZhai SeniorZhai marked this pull request as ready for review June 10, 2026 06:15
@SeniorZhai SeniorZhai requested a review from Copilot June 17, 2026 05:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses dark mode styling regressions by replacing hardcoded color literals and fixed color resources with theme attributes, ensuring UI elements adapt correctly across light/night themes.

Changes:

  • Updated multiple XML drawables/layouts to use theme attributes (e.g., ?attr/bg_menu_border, ?attr/color_accent, ?attr/bg_divider, ?attr/bg_gray_light) instead of hardcoded colors.
  • Updated sticker album “Added” state to resolve the accent color from the current theme (colorFromAttribute(R.attr.color_accent)).
  • Adjusted Compose DestinationMenu icon tint to use MixinAppTheme.colors.iconGray for better dark mode consistency.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
app/src/main/res/layout/view_swap_alert.xml Uses themed divider color via ?attr/bg_divider instead of a hardcoded translucent black.
app/src/main/res/drawable/selector_radio.xml Switches radio strokes to themed border/accent attributes for proper dark mode rendering.
app/src/main/res/drawable/selector_radio_badge.xml Same as above for the “badge” variant to keep borders consistent in night mode.
app/src/main/res/drawable/ic_selected.xml Replaces hardcoded selected color with theme accent attribute.
app/src/main/res/drawable/ic_not_selected.xml Replaces hardcoded unselected fill with themed border color attribute.
app/src/main/res/drawable/ic_group_select_close.xml Uses themed gray for the circle and hardcodes the close glyph to white for visibility in dark mode.
app/src/main/res/drawable/bg_round_gray_btn.xml Makes enabled/disabled fills theme-driven for dark mode correctness.
app/src/main/res/drawable/bg_circle.xml Uses themed light-gray background instead of a fixed light color.
app/src/main/java/one/mixin/android/ui/sticker/AlbumAdapter.kt Resolves “Added” text color from the theme instead of a fixed color resource.
app/src/main/java/one/mixin/android/ui/address/component/DestinationMenu.kt Uses iconGray tint for menu icons to align with dark mode palette.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SeniorZhai SeniorZhai closed this Jun 17, 2026
@SeniorZhai SeniorZhai deleted the fix/dark-mode branch June 17, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants