Fix dark mode styling regressions#6354
Closed
SeniorZhai wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses dark mode styling regressions by replacing hardcoded color literals and fixed color resources with theme attributes, ensuring UI elements adapt correctly across light/night themes.
Changes:
- Updated multiple XML drawables/layouts to use theme attributes (e.g.,
?attr/bg_menu_border,?attr/color_accent,?attr/bg_divider,?attr/bg_gray_light) instead of hardcoded colors. - Updated sticker album “Added” state to resolve the accent color from the current theme (
colorFromAttribute(R.attr.color_accent)). - Adjusted Compose
DestinationMenuicon tint to useMixinAppTheme.colors.iconGrayfor better dark mode consistency.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/layout/view_swap_alert.xml | Uses themed divider color via ?attr/bg_divider instead of a hardcoded translucent black. |
| app/src/main/res/drawable/selector_radio.xml | Switches radio strokes to themed border/accent attributes for proper dark mode rendering. |
| app/src/main/res/drawable/selector_radio_badge.xml | Same as above for the “badge” variant to keep borders consistent in night mode. |
| app/src/main/res/drawable/ic_selected.xml | Replaces hardcoded selected color with theme accent attribute. |
| app/src/main/res/drawable/ic_not_selected.xml | Replaces hardcoded unselected fill with themed border color attribute. |
| app/src/main/res/drawable/ic_group_select_close.xml | Uses themed gray for the circle and hardcodes the close glyph to white for visibility in dark mode. |
| app/src/main/res/drawable/bg_round_gray_btn.xml | Makes enabled/disabled fills theme-driven for dark mode correctness. |
| app/src/main/res/drawable/bg_circle.xml | Uses themed light-gray background instead of a fixed light color. |
| app/src/main/java/one/mixin/android/ui/sticker/AlbumAdapter.kt | Resolves “Added” text color from the theme instead of a fixed color resource. |
| app/src/main/java/one/mixin/android/ui/address/component/DestinationMenu.kt | Uses iconGray tint for menu icons to align with dark mode palette. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.