Skip to content

GEOPY-2665: Accept 2D inversion mesh (DrapeModel) in sensitivity_cutoff application#404

Open
benk-mira wants to merge 4 commits intorelease/GA_4.8from
GEOPY-2665
Open

GEOPY-2665: Accept 2D inversion mesh (DrapeModel) in sensitivity_cutoff application#404
benk-mira wants to merge 4 commits intorelease/GA_4.8from
GEOPY-2665

Conversation

@benk-mira
Copy link
Copy Markdown
Contributor

@benk-mira benk-mira commented May 8, 2026

GEOPY-2665 - Accept 2D inversion mesh (DrapeModel) in sensitivity_cutoff application

Copilot AI review requested due to automatic review settings May 8, 2026 21:49
@github-actions github-actions Bot changed the title GEOPY-2665 GEOPY-2665: Accept 2D inversion mesh (DrapeModel) in sensitivity_cutoff application May 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends the Depth of Investigation “Sensitivity Cutoff” app to accept/use 2D DrapeModel meshes in addition to Octree, aligning the options typing and UI configuration with broader mesh support in the codebase.

Changes:

  • Allow SensitivityCutoffOptions.mesh to be Octree | DrapeModel.
  • Update the app UI JSON to permit selecting a DrapeModel mesh type.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
simpeg_drivers/depth_of_investigation/sensitivity_cutoff/options.py Broadens the accepted mesh type annotation/imports to include DrapeModel.
simpeg_drivers-assets/uijson/sensitivity_cutoff.ui.json Adds DrapeModel’s type UUID to the allowed mesh types in the UI definition.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread simpeg_drivers/depth_of_investigation/sensitivity_cutoff/options.py
Comment thread simpeg_drivers/depth_of_investigation/sensitivity_cutoff/options.py
Comment thread simpeg_drivers-assets/uijson/sensitivity_cutoff.ui.json Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.34%. Comparing base (28e347e) to head (f047b43).

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/GA_4.8     #404      +/-   ##
==================================================
- Coverage           90.36%   90.34%   -0.02%     
==================================================
  Files                 110      110              
  Lines                6527     6527              
  Branches              826      826              
==================================================
- Hits                 5898     5897       -1     
  Misses                416      416              
- Partials              213      214       +1     
Files with missing lines Coverage Δ
...pth_of_investigation/sensitivity_cutoff/options.py 92.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

benk-mira and others added 3 commits May 8, 2026 14:59
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants