GEOPY-2665: Accept 2D inversion mesh (DrapeModel) in sensitivity_cutoff application#404
Open
benk-mira wants to merge 4 commits intorelease/GA_4.8from
Open
GEOPY-2665: Accept 2D inversion mesh (DrapeModel) in sensitivity_cutoff application#404benk-mira wants to merge 4 commits intorelease/GA_4.8from
sensitivity_cutoff application#404benk-mira wants to merge 4 commits intorelease/GA_4.8from
Conversation
sensitivity_cutoff application
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the Depth of Investigation “Sensitivity Cutoff” app to accept/use 2D DrapeModel meshes in addition to Octree, aligning the options typing and UI configuration with broader mesh support in the codebase.
Changes:
- Allow
SensitivityCutoffOptions.meshto beOctree | DrapeModel. - Update the app UI JSON to permit selecting a DrapeModel mesh type.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| simpeg_drivers/depth_of_investigation/sensitivity_cutoff/options.py | Broadens the accepted mesh type annotation/imports to include DrapeModel. |
| simpeg_drivers-assets/uijson/sensitivity_cutoff.ui.json | Adds DrapeModel’s type UUID to the allowed mesh types in the UI definition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/GA_4.8 #404 +/- ##
==================================================
- Coverage 90.36% 90.34% -0.02%
==================================================
Files 110 110
Lines 6527 6527
Branches 826 826
==================================================
- Hits 5898 5897 -1
Misses 416 416
- Partials 213 214 +1
🚀 New features to boost your workflow:
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2665 - Accept 2D inversion mesh (DrapeModel) in
sensitivity_cutoffapplication