GEOPY-2590: B#403
Merged
domfournier merged 2 commits intorelease/GA_4.8from May 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates inversion uncertainty validation to ignore NDV/invalid uncertainty entries where the corresponding data are also NDV (NaN), and extends the MT regression test to cover this behavior.
Changes:
- Refine
BaseInversionOptions.uncertaintiesvalidation to only flag NaN/negative uncertainties where data are finite. - Extend MT test to include an uncertainty NDV case that should be ignored because the paired data are also NDV.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
simpeg_drivers/options.py |
Masks uncertainty validation by data NaNs to avoid flagging uncertainties on NDV data. |
tests/run_tests/driver_mt_test.py |
Adds a regression case ensuring uncertainties with NDV are not flagged when the corresponding data are also NDV. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+635
to
+638
| for uncert, data in zip( | ||
| out[k].values(), self.component_data(k).values(), strict=True | ||
| ): | ||
| if np.any((np.isnan(uncert) | (uncert < 0)) & ~np.isnan(data)): |
Collaborator
Author
There was a problem hiding this comment.
Na, we know they always have the same lenght
benk-mira
approved these changes
May 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/GA_4.8 #403 +/- ##
==================================================
+ Coverage 90.34% 90.36% +0.01%
==================================================
Files 110 110
Lines 6527 6527
Branches 826 826
==================================================
+ Hits 5897 5898 +1
Misses 416 416
+ Partials 214 213 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2590 - Add validator for negative on NDV values in uncertainties