Repository navigation
Fix fuel checks in recipe viewers on NeoForge 1.21.1 - #15
Merged
SkyBlade1978 merged 2 commits intoNov 11, 2026
Merged
SkyBlade1978 merged 2 commits into
SkyBlade1978 merged 2 commits into
Conversation
SkyBlade1978
merged commit Nov 11, 2026
4a4f892
into
MinecraftModDevelopmentMods:master-1.21.1-neo
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the negative burn-time error when recipe viewers scan non-wood building pieces. This also covers BOP and Mineralogy pieces. Non-wood pieces now use NeoForge's normal fuel lookup, including datapack overrides; wooden pieces keep their proportional fuel values.
The reported errors were reproduced with the published jar before the correction. Checks now cover all pieces and the general fuel query, on the client render thread before opening a world and after joining it, plus standalone and combined server starts and reloads. The datapack override control, 127 unit tests, resource checks, builds, Javadocs and Eclipse isolation pass. Manual testing has passed too.
Player jar SHA-256:
C7E8A84301076CE56CDFEA34186AD6EA9AF81D70C8B7489CE1026CDEA2C346A3.Release 0.3.11.121012 after the required checks pass. Keep the existing single-attempt CurseForge upload safeguard.