Repository navigation
Keep saved ore settings when providers rename rules - #339
Merged
SkyBlade1978 merged 1 commit intoNov 12, 2026
Merged
SkyBlade1978 merged 1 commit into
SkyBlade1978 merged 1 commit into
Conversation
SkyBlade1978
merged commit Nov 12, 2026
101fd12
into
MinecraftModDevelopmentMods:master-26.1.2
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stops renamed Base Metals ore rules from adding a second generation pass to existing profiles. Saved settings stay in place, and matching modern rules remain available as disabled alternatives.
I've bumped Forge 26.1.2 to 4.1.1 and updated the changelog. The local test suite, packaged client/server checks, and real Base Metals restart and generation checks pass on Forge 64.0.9 and 64.1.5.
Profiles that already contain both rules are left alone so deliberate choices aren't changed. Existing chunks are not regenerated.