Skip to content

fix(#772): tag admin/fraud routes and role-restricted Swagger badge#860

Merged
nanaf6203-bit merged 1 commit into
MettaChain:mainfrom
kilodesodiq-arch:fix/issue-772-api-tags-admin-fraud
Jun 30, 2026
Merged

fix(#772): tag admin/fraud routes and role-restricted Swagger badge#860
nanaf6203-bit merged 1 commit into
MettaChain:mainfrom
kilodesodiq-arch:fix/issue-772-api-tags-admin-fraud

Conversation

@kilodesodiq-arch

@kilodesodiq-arch kilodesodiq-arch commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Closes #772
Closes #771
Closes #773
Closes #774

  • Verified admin.controller.ts already carries @apitags('Admin') at the controller level (no change required there)
  • Added @apitags('Fraud') at the method level on the 8 fraud-related endpoints in admin.controller.ts. NestJS Swagger accumulates the tag list per operation so these endpoints now appear under both Admin and Fraud sections in the Swagger UI without altering their /admin/fraud/* URL paths
  • Registered Admin and Fraud tag descriptions in setupSwagger with explicit 'admin role only (role-restricted)' hints — that's the role-restricted badge from the issue
  • src/fraud/fraud.controller.ts does not exist in this codebase today; fraud operations currently nest inside admin.controller.ts. Tagging them at the method level preserves URL stability. Extracting into a dedicated FraudController is recommended as a follow-up (will require API URL changes from /admin/fraud/* to /fraud/*)

…gger badges

- Add @apitags('Fraud') at method-level on all 8 fraud endpoints in admin.controller.ts so they appear under the Fraud tag section in Swagger (operations keep their Admin tag too)
- Register tag descriptions 'Admin' and 'Fraud' in setupSwagger with explicit role-restricted ('admin role only') hints, providing the role-restricted badge called out in the issue
- Note: src/fraud/fraud.controller.ts does not currently exist; fraud routes are nested under /admin/fraud/* in admin.controller.ts. Extracting into a dedicated FraudController is left for a follow-up issue since it would break URL paths
@drips-wave

drips-wave Bot commented Jun 30, 2026

Copy link
Copy Markdown

@kilodesodiq-arch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@nanaf6203-bit nanaf6203-bit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanaf6203-bit nanaf6203-bit merged commit a43452e into MettaChain:main Jun 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants