feat: implement #723, #725, #726, #727 - IP block, audit-log validation#848
Merged
nanaf6203-bit merged 3 commits intoJun 29, 2026
Merged
Conversation
|
@monique-7arch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
monique-7arch
force-pushed
the
feat/monique-7arch-issues
branch
from
9792fff to
fa42766
Compare
…Chain#727 - IP block, audit-log validation
monique-7arch
force-pushed
the
feat/monique-7arch-issues
branch
from
fa42766 to
221d266
Compare
IsISO8601 + Type(() => Date) fails validation because class-transformer converts the string to a Date before class-validator runs. IsDateString validates the raw string input correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #723, Closes #725, Closes #726, Closes #727
#723 - Block re-registration from same IP
Added in-memory IP tracking to prevent registration from the same IP until the pending email verification is completed or expires. registrationIpMap tracks IP-to-email mappings. IP entry is cleared on successful verification or token expiry.
#725 - Add @type(() => Date) to audit-log DTO
Already implemented - audit-log-query.dto.ts has @type(() => Date) on both dateFrom and dateTo.
#726 - Add @IsOptional and @IsISO8601
Already implemented - DTO has @IsOptional() and @IsISO8601() on date fields.
#727 - Add validation tests for audit-log date params
Added unit tests verifying malformed date strings return 400 rather than 500.