Repository navigation
Conversation
Add a MYSQL_HOST switch to the test settings and a CI job that runs the suite on MySQL 8.4 and MariaDB 11.4. Skip the zero primary key tests where the backend can't store a zero AutoField, and document that the default _ai_ci collations ignore accents in every ranking tier but the start of a word.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a CI job that runs the test suite on MySQL 8.4 and MariaDB 11.4, so izaya can say it supports them rather than ruling them out.
tests/settings.py: settingMYSQL_HOST(and optionallyMYSQL_PORT,MYSQL_USERandMYSQL_PASSWORD) switches the tests to MySQL, just asPGHOSTswitches them to PostgreSQL.testing.yml: a newmysqljob runs once with MySQL and once with MariaDB, using a service container, themysqlclientdriver and Python 3.14. Like the PostgreSQL job, it skips the browser tests.0in anAutoField, as on MySQL and MariaDB.The rest of the suite, ranking included, passes unchanged on both.
Ranking and accents
With their default
_ai_cicollations, MySQL and MariaDB ignore accents iniexact,istartswithandicontains, but not iniregex. Ranking usesiregexto find matches at the start of a word, so for the querycafe, "Café" ranks as a whole-value match but "Le Café" ranks with everything else rather than as a word-start match. I've documented this in the README rather than changed it.