Skip to content

docs(testing): encode CV independent-load and mockReset flake rules - #181

Merged
racitores merged 1 commit into
mainfrom
docs/cv-independent-loading-phases
Sep 23, 2026
Merged

racitores merged 1 commit into
mainfrom
docs/cv-independent-loading-phases

Conversation

@racitores

Copy link
Copy Markdown
Contributor

Description

Adds the component-view flake learnings that were missing from the Mobile testing skill (sibling loading phases, empty-state/list hydration, mockReset vs clearAllMocks, delayed negative asserts). Existing CV rules for nested findBy*, stale press, and awaiting gated content are unchanged.

flaky-test-detection now routes *.view.test.ts(x) to component-view instead of unit fake-timer patterns (J2 / J8).

Type of Change

  • Skill improvement/update
  • New skill
  • Bug fix
  • Documentation update
  • Other (please describe):

Checklist

  • I have read the CONTRIBUTING.md guidelines
  • My skill follows the SKILL_TEMPLATE.md format
  • I have tested this skill with an AI agent
  • My skill does not contain any secrets, private keys, or sensitive data
  • I have added appropriate documentation
  • My changes don't break existing skills

Testing

Docs-only. Reviewed against existing CV golden rules 10/14/15 to avoid duplication; new checklist items 16–19 and diagnosing-table rows cover the remaining families.

Additional Context

Companion experimental-task PR: https://github.com/MetaMask/experimental-mm-qa-ai-tasks/pull/271

Test plan

  • Open mobile-testing CV writing-tests / reference when writing or fixing a *.view.test.tsx
  • Confirm independent-load, empty-state, list completeness, and mockReset appear in the self-review checklist and diagnosing table
  • Confirm flaky-test-detection does not recommend fake timers for view tests

Made with Cursor

CV flakes often come from awaiting a sibling skeleton, asserting empty-state or list rows before hydration, or using clearAllMocks after a test mutates Engine implementations. Route *.view.test files away from unit fake-timer patterns.

Co-authored-by: Cursor <cursoragent@cursor.com>
@racitores
racitores enabled auto-merge (squash) September 23, 2026 12:25
@racitores
racitores merged commit f4f14e3 into main Sep 23, 2026
28 checks passed
@racitores
racitores deleted the docs/cv-independent-loading-phases branch September 23, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants