Skip to content

fix(solana): create solana pending transactions - #370

Merged
taran-a merged 2 commits into
mainfrom
fix/solana-pending-transactions
Sep 25, 2026
Merged

taran-a merged 2 commits into
mainfrom
fix/solana-pending-transactions

Conversation

@taran-a

@taran-a taran-a commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Explanation

The snap only emitted AccountTransactionsUpdated once a transaction reached its
commitment — always terminal (confirmed/failed), never unconfirmed. The
extension's toast system needs an unconfirmed event to show "Transaction submitted"
and gates the terminal toast on it, so no toasts ever appeared for Solana
transactions
(send, swap, or bridge). All sibling snaps (Bitcoin, Tron, Stellar)
already emit a pending transaction at broadcast time.

This adds TransactionMapper.createPendingTransaction and saves/emits it in
WalletService.signAndSendTransaction right after broadcasting, before arming the
SignatureMonitor (guaranteeing ordering). The confirmed transaction later upserts
over it by id. Covers all flows, since every submission path goes through this method.

Screen.Recording.2026-09-24.at.18.12.50.mov

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@taran-a
taran-a requested a review from a team as a code owner September 24, 2026 16:55
@taran-a
taran-a deployed to default-branch September 24, 2026 16:55 — with GitHub Actions Active
@Battambang

Copy link
Copy Markdown
Contributor

Some little code coverage to get there to pass CI: Jest: "global" coverage threshold for lines (86.88%) not met: 86.87%

@taran-a
taran-a force-pushed the fix/solana-pending-transactions branch from 1832679 to 9c5fad3 Compare September 24, 2026 17:30
@sonarqubecloud

Copy link
Copy Markdown

@taran-a
taran-a requested a review from Battambang September 24, 2026 19:21

@Battambang Battambang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one

@ulissesferreira

Copy link
Copy Markdown
Contributor

Back in the day we didn't have the pending then confirmed pattern nailed down so this improvement never got added in. And since Solana transactions happened so fast we never really focused on it. But it's this kind of polish that makes things look neat ✨

@taran-a
taran-a added this pull request to the merge queue Sep 25, 2026
Merged via the queue into main with commit 21cbb0c Sep 25, 2026
55 checks passed
@taran-a
taran-a deleted the fix/solana-pending-transactions branch September 25, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants