fix(solana): create solana pending transactions - #370
Merged
Merged
Conversation
Contributor
|
Some little code coverage to get there to pass CI: |
taran-a
force-pushed
the
fix/solana-pending-transactions
branch
from
September 24, 2026 17:30
1832679 to
9c5fad3
Compare
Battambang
reviewed
Sep 24, 2026
|
ulissesferreira
approved these changes
Sep 25, 2026
Contributor
|
Back in the day we didn't have the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Explanation
The snap only emitted
AccountTransactionsUpdatedonce a transaction reached itscommitment — always terminal (
confirmed/failed), neverunconfirmed. Theextension's toast system needs an
unconfirmedevent to show "Transaction submitted"and gates the terminal toast on it, so no toasts ever appeared for Solana
transactions (send, swap, or bridge). All sibling snaps (Bitcoin, Tron, Stellar)
already emit a pending transaction at broadcast time.
This adds
TransactionMapper.createPendingTransactionand saves/emits it inWalletService.signAndSendTransactionright after broadcasting, before arming theSignatureMonitor(guaranteeing ordering). The confirmed transaction later upsertsover it by id. Covers all flows, since every submission path goes through this method.
Screen.Recording.2026-09-24.at.18.12.50.mov
References
Checklist