chore: document some edge case scenarios#188
Open
MoMannn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
Note
Low Risk
Markdown-only documentation updates with no changes to contracts or execution paths.
Overview
Adds documentation-only security guidance for caveat enforcer edge cases—no contract or runtime behavior changes.
CaveatEnforcers.mdnow briefly describesAllowedTargetsEnforcer/AllowedMethodsEnforcer(outer-call guards only) andERC20PeriodTransferEnforcer, each with a warning and a link intoSecurity.md.Security.mdgains a Caveat Enforcer Combination Risks section covering two scenarios: allowingredeemDelegationsviaAllowedMethodsEnforceron a self-targeted delegation (nested calldata not checked → apparent narrow permission can become arbitrary execution), and attaching multipleERC20PeriodTransferEnforcercaveats to one delegation (shared(delegationManager, delegationHash)state → only the first initializer’s terms apply).Reviewed by Cursor Bugbot for commit e4126b8. Bugbot is set up for automated code reviews on this repo. Configure here.