feat: open pull requests for security advisories - #10496
Open
cryptodev-2s wants to merge 1 commit into
Open
cryptodev-2s wants to merge 1 commit into
cryptodev-2s wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4468bca. Configure here.
| "dependencyDashboard": true, | ||
| "dependencyDashboardApproval": true, | ||
| "minimumReleaseAge": "3 days", | ||
| "osvVulnerabilityAlerts": true, |
There was a problem hiding this comment.
Security PRs may miss fresh patches
Medium Severity
osvVulnerabilityAlerts plus the existing 3-day minimumReleaseAge can drop a just-released patched version as pending before vulnerabilityAlerts overrides apply. A [SECURITY] PR may then target an older still-vulnerable release, so merging it does not remediate the advisory.
Reviewed by Cursor Bugbot for commit 4468bca. Configure here.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Explanation
Renovate currently opens nothing for security advisories. Every run logs:
osvVulnerabilityAlertsmakes it read advisories from osv.dev instead of GitHub's alerts API, which needs no new token permission. That matters here: granting the App a permission it does not already hold fails at the exchange with a 500 rather than degrading, which is what happened withstatuses: writein #10316 and had to be reverted by #10317. This route works today with the token we already have.No other config is needed. Renovate's
vulnerabilityAlertsdefaults already do the right thing for us:dependencyDashboardApproval: falseminimumReleaseAge: nullprCreation: 'immediate',prConcurrentLimit: 0rangeStrategy: 'update-lockfile'commitMessageSuffix: '[SECURITY]'Important
Dependabot security updates are still enabled, so for a while both bots will open a pull request for the same advisory. That is the point at which we can decide whether Renovate replaces Dependabot here, and it is worth watching for the first few advisories rather than assuming.
Two known limits:
osvVulnerabilityAlertsis marked experimental upstream (renovate#20542), and theCannot access vulnerability alertswarning will keep appearing, since Renovate still tries GitHub's API as well.References
Follows #10495. Part of WPC-1161.
Checklist
Note
Low Risk
Single Renovate config flag with no application code changes; main operational note is possible duplicate security PRs alongside Dependabot and upstream’s experimental OSV support.
Overview
Turns on
osvVulnerabilityAlertsinrenovate.jsonso Renovate can open pull requests for known vulnerabilities using osv.dev instead of GitHub’s vulnerability alerts API, which the current App token cannot access (and expanding permissions has failed before).Security fix PRs should still follow Renovate’s built-in vulnerability defaults (immediate creation, bypass of the dependency dashboard approval and 3-day
minimumReleaseAge,[SECURITY]suffix, lockfile-focused updates). Dependabot security updates remain on, so duplicate advisory PRs are possible until the team decides to consolidate bots.Reviewed by Cursor Bugbot for commit 4468bca. Bugbot is set up for automated code reviews on this repo. Configure here.