fix(deps): update dependency cockatiel to v4 - #10381
Open
metamask-ci[bot] wants to merge 4 commits into
Open
metamask-ci[bot] wants to merge 4 commits into
metamask-ci[bot] wants to merge 4 commits into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
# Conflicts: # eslint-suppressions.json # packages/base-data-service/CHANGELOG.md # packages/base-data-service/package.json # packages/controller-utils/CHANGELOG.md # packages/controller-utils/package.json # packages/core-backend/CHANGELOG.md # packages/core-backend/package.json # packages/network-controller/CHANGELOG.md # packages/network-controller/package.json # packages/shield-controller/CHANGELOG.md # packages/shield-controller/package.json # yarn.lock
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^3.1.2→^4.0.0Release Notes
connor4312/cockatiel (cockatiel)
v4.0.0Compare Source
as Error; callback and result types now reflectunknownfor thrown values (#97)halfOpenSamplingoption to the circuit breaker (#73)CountBreakerandSamplingBreakergetters/setters viastructuredClone(#113)TaskCancelledErroris not thrown on cooperative timeouts (#98)AbortSignal(#116)Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate CLI.
Note
Medium Risk
Changes retry and circuit-breaker dependency versions and error-handling signatures on RPC and shield polling paths; test-only ESM shimming limits runtime risk but those code paths warrant regression testing.
Overview
Upgrades cockatiel from
^3.2.1to^4.0.0across packages that use it for retries and circuit breakers (base-data-service,controller-utils,core-backend,network-controller,shield-controller), with matching changelog and lockfile updates. The root monorepo also addscockatielas a devDependency for the shared test setup.Because v4 ships as ESM-only, package tests (compiled to CommonJS) get a Jest bridge:
setupCockatiel.mjsloads the real module via the ESM loader,tests/cockatiel.cjsre-exports it onglobalThis, andjest.config.packages.cjsmapscockatielto that shim so Node 22 can run tests without synchronousrequire(esm).Application code aligns with v4’s
unknownerror typing: RPC retry helpers innetwork-controller(isHttpServerError,isTimeoutError,isConnectionResetError) and#shouldRetryinshield-controllernow acceptunknownand guard withisObject/hasPropertyinstead of assumingError.Reviewed by Cursor Bugbot for commit 26ecc8f. Bugbot is set up for automated code reviews on this repo. Configure here.