docs(fold): open item 4 records TestMulGatherQMMGlobalScale's pass on Metal; BINARIES links the item - #406
Merged
Conversation
… Metal; BINARIES links the item The follow-ups from #404's review: - The fold record's open item 4, and the gate 4 bullet that matches it, named only CUDA's pass with the gate widened. The test runs ungated on Metal, where it passed on the release build (#404). - Open item 5 cites #404 beside #402 for Metal's gate 4. - BINARIES.md cited "open item 4", but that file has no open items; it now links the fold record's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes notes 1 and 2 from #404's review (comment). Docs only, two files.
TestMulGatherQMMGlobalScale"is gated to Metal upstream and passes on CUDA with the gate widened". It now also says the test passes on Metal on the release build (docs(fold): Metal's vision goldens per model and the ./mlx tests, on the release build #404)../mlxtests.BINARIES.mdcited "(open item 4)", but that file has no open items. The citation now links the fold record's open items.Notes 3 and 4 need the Metal host's data, so they are not in this PR: the 26b and 12b digests, and whether
-count=1ran.Checks:
check_source_paths.py --changed-since origin/mainis clean.BINARIES.mdrow keeps its seven column separators.#open-itemsanchor exist.ai-server/mlx-cuda🤖 Generated with Claude Code