server: pin the in-lock runner log attrs, and correct the divergence note - #291
Merged
Merged
Conversation
…note The claim that upstream's TryLock LogValue costs us the fields we read is now a test rather than an assertion: log a runner while holding refMu, exactly as sched.go:433 does, and assert name/inference/pid/num_ctx survive. It passes on ours and fails on all four with upstream 0.34.0's LogValue pasted in, which is what pins the divergence at the next sync. Also corrects an overstatement in the note: these are slog.Debug lines and only one run this week was captured at debug level, so 'the lines we read all week' was wrong. The narrower claim -- they carry the fields we need when diagnosing a runner, and upstream drops them at the eleven in-lock sites -- is what the evidence supports. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #289 and #290: turns the reason we keep our
LogValueinto a test, and corrects an overstatement in the divergence note.TestRunnerRefLogValueKeepsFieldsUnderRefMulogs a runner while holdingrefMu, exactly assched.go:433does, and assertsname,inference,pidandnum_ctxsurvive. It passes on ours; with upstream 0.34.0'sLogValuepasted in it fails on all four attrs (negative control run, output in the commit message). That is what pins the divergence when the 0.34.0 fold reachesLogValue.slog.Debuglines, and only one run this week was captured at debug level (the 2026-09-06 array-trace probe, which does showsched.go:433 … runner.name=…gemma4:12b-nvfp4 runner.pid=316 runner.num_ctx=65536). The campaign logs run at INFO and never carried them. The narrower, supported claim replaces it.🤖 Generated with Claude Code