Skip to content

fix(ui): 'Open in default app' in the right-click menus #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maxaubert merged 1 commit into from
Oct 5, 2026
Merged

fix(ui): 'Open in default app' in the right-click menus #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/rowmenu.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ test('right-clicking an unselected row selects it and opens its menu', async ()
await expect(item('Retry')).toBeDisabled()
await expect(item('Stop')).toBeDisabled()
// Keyboard: focus starts on the first entry and arrows walk the live ones.
await expect(item('Open')).toBeFocused()
await expect(item('Open in default app')).toBeFocused()
await page.keyboard.press('ArrowDown')
await expect(item('Show in File Explorer')).toBeFocused()
await page.keyboard.press('Escape')
Expand All @@ -80,7 +80,7 @@ test('a multi-selection menu counts, and Preview and Info show no single file',
await row('bravo').click({ button: 'right' })
await expect(item('Remove 3 from list')).toBeVisible()
await expect(item('Delete 3 files')).toBeVisible()
await expect(item('Open')).toBeDisabled()
await expect(item('Open in default app')).toBeDisabled()
await expect(item('Show in File Explorer')).toBeDisabled()
await expect(item('Retry')).toBeEnabled()
// Delete asks first, names the count and the Recycle Bin; cancel leaves all.
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "filesmith",
"version": "0.6.0",
"version": "0.6.1",
"description": "A desktop file toolkit: convert, compress, resize, upscale, remove backgrounds, and PDF tools.",
"author": "Max",
"license": "MIT",
Expand Down
8 changes: 6 additions & 2 deletions src/renderer/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,11 @@ export default function App(): JSX.Element {
x,
y,
items: [
{ label: 'Open', icon: 'eye', onClick: () => openExternally('output', item) },
{
label: 'Open in default app',
icon: 'arrow',
onClick: () => openExternally('output', item)
},
{
label: 'Show in File Explorer',
icon: 'folder',
Expand Down Expand Up @@ -683,7 +687,7 @@ export default function App(): JSX.Element {
x,
y,
items: [
{ label: 'Open', icon: 'eye', onClick: () => previewGen(path) },
{ label: 'Preview', icon: 'eye', onClick: () => previewGen(path) },
{
label: 'Open in default app',
icon: 'arrow',
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/src/components/queue/rowMenu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export function rowMenuModel(targets: QueueItem[], queue: QueueItem[]): RowMenuE
const retries = targets.filter(retryable).length
const clearable = queue.filter(finished).length
return [
{ action: 'open', label: 'Open', icon: 'eye', disabled: !one },
{ action: 'open', label: 'Open in default app', icon: 'arrow', disabled: !one },
{
action: 'reveal',
label: 'Show in File Explorer',
Expand Down
Loading