Add SudoPassCmd configuration for more convenience#112
Merged
Conversation
MaxG87
force-pushed
the
copilot/add-configuration-better-backup
branch
7 times, most recently
from
7053958 to
bed6d03
Compare
MaxG87
force-pushed
the
copilot/add-configuration-better-backup
branch
from
b2f863d to
6ce76a6
Compare
Rename the existing `Configuration` union type alias to `DeviceConfiguration`
and introduce a new `Configuration` BaseModel that wraps the list of device
configurations under a `deviceConfigurations` field.
For TOML, the parent section is now `butter-backup` with the array of device
entries under `device-configurations`:
[[butter-backup.device-configurations]]
Name = "..."
For JSON/JSON5/YAML the wrapper key is `deviceConfigurations`:
{ "deviceConfigurations": [...] }
Update all callers, tests, and example config files accordingly.
Agent-Logs-Url: https://github.com/MaxG87/ButterBackup/sessions/8df34a6f-2b3a-4151-8bd2-1d7d91224187
Co-authored-by: MaxG87 <5477952+MaxG87@users.noreply.github.com>
Add an optional `SudoPassCmd: str | None = None` field to the `Configuration` model. When set, it holds a shell command whose stdout is a sudo password that can be used to refresh the sudo credential cache. Agent-Logs-Url: https://github.com/MaxG87/ButterBackup/sessions/8df34a6f-2b3a-4151-8bd2-1d7d91224187 Co-authored-by: MaxG87 <5477952+MaxG87@users.noreply.github.com>
MaxG87
force-pushed
the
copilot/add-configuration-better-backup
branch
from
6ce76a6 to
4dec085
Compare
When `SudoPassCmd` is set in the configuration, run `SudoPassCmd | sudo -Sv` to refresh the sudo credential cache: - before device decryption in the `open` command - before device decryption in the `backup` command - before unmounting in the `close` command This prevents interactive password prompts during long backup sessions. Agent-Logs-Url: https://github.com/MaxG87/ButterBackup/sessions/8df34a6f-2b3a-4151-8bd2-1d7d91224187 Co-authored-by: MaxG87 <5477952+MaxG87@users.noreply.github.com>
…h backends Agent-Logs-Url: https://github.com/MaxG87/ButterBackup/sessions/e6ccb9d7-94a9-41e0-91ba-3fe37e740580 Co-authored-by: MaxG87 <5477952+MaxG87@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MaxG87/ButterBackup/sessions/c3eca6b4-12ee-4225-864d-0f6c4d8eda57 Co-authored-by: MaxG87 <5477952+MaxG87@users.noreply.github.com>
MaxG87
force-pushed
the
copilot/add-configuration-better-backup
branch
from
4dec085 to
5e475e8
Compare
Agent-Logs-Url: https://github.com/MaxG87/ButterBackup/sessions/c3eca6b4-12ee-4225-864d-0f6c4d8eda57 Co-authored-by: MaxG87 <5477952+MaxG87@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MaxG87/ButterBackup/sessions/c3eca6b4-12ee-4225-864d-0f6c4d8eda57 Co-authored-by: MaxG87 <5477952+MaxG87@users.noreply.github.com>
While here, two explicit composite strategies were rewritten to be just strategies.
The file got way too long. All tests regarding sudo_pass_cmd are extracted into their own file for now.
MaxG87
force-pushed
the
copilot/add-configuration-better-backup
branch
from
5e475e8 to
15033b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.