[agent] cleanup: relocate evaluation logic and remove package-lock.json - #386
[agent] cleanup: relocate evaluation logic and remove package-lock.json#386google-labs-jules[bot] wants to merge 5 commits into
Conversation
Moves `evaluators.py` to its correct architectural location in `src/agent/evaluation.py` and cleans up an accidental `package-lock.json` file in the root directory while adding it to `.gitignore` to enforce `pnpm-lock.yaml`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis cleanup moves evaluation logic into the agent source package, updates the benchmark orchestration script to import it from its new location, and removes the accidental root npm lockfile in favor of the repository’s pnpm lockfile conventions. Backend and frontend test suites passed. Flow diagram for repository lockfile cleanupflowchart LR
RootNpm[Accidental root package-lock.json] -->|deleted and ignored| Repository[Repository lockfile policy]
Pnpm[frontend/pnpm-lock.yaml] -->|retained and updated| Repository
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
…and fix CI Moves `evaluators.py` to its correct architectural location in `src/agent/evaluation.py` and cleans up an accidental `package-lock.json` file in the root directory while adding it to `.gitignore` to enforce `pnpm-lock.yaml`. Also fixes GitHub Actions CI failure: - Node.js 20 was deprecated and causing CI warnings/failures in github actions runner, updated to `node-version: ['24']`. - Updated `npm` commands to `pnpm` in `.github/workflows/pr-check.yml` to correctly use `pnpm-lock.yaml`. - Added `pnpm/action-setup@v3` to install pnpm in CI workflow.
…and fix CI Moves `evaluators.py` to its correct architectural location in `src/agent/evaluation.py` and cleans up an accidental `package-lock.json` file in the root directory while adding it to `.gitignore` to enforce `pnpm-lock.yaml`. Also fixes GitHub Actions CI failure: - Node.js 20 was deprecated and causing CI warnings/failures in github actions runner, updated to `node-version: ['24']`. - Updated `npm` commands to `pnpm` in `.github/workflows/pr-check.yml` to correctly use `pnpm-lock.yaml`. - Added `pnpm/action-setup@v4` with version `9` to install pnpm in CI workflow.
…and fix CI Moves `evaluators.py` to its correct architectural location in `src/agent/evaluation.py` and cleans up an accidental `package-lock.json` file in the root directory while adding it to `.gitignore` to enforce `pnpm-lock.yaml`. Also fixes GitHub Actions CI failure: - Node.js 20 was deprecated and causing CI warnings/failures in github actions runner, updated to `node-version: ['24']`. - Updated `npm` commands to `pnpm` in `.github/workflows/pr-check.yml` to correctly use `pnpm-lock.yaml`. - Added `pnpm/action-setup@v4` with `version: "9"` to install pnpm in CI workflow and satisfy SonarCloud security requirements for string versions.
…and fix CI Moves `evaluators.py` to its correct architectural location in `src/agent/evaluation.py` and cleans up an accidental `package-lock.json` file in the root directory while adding it to `.gitignore` to enforce `pnpm-lock.yaml`. Also fixes GitHub Actions CI failure: - Node.js 20 was deprecated and causing CI warnings/failures in github actions runner, updated to `node-version: ['24']`. - Updated `npm` commands to `pnpm` in `.github/workflows/pr-check.yml` to correctly use `pnpm-lock.yaml`. - Removed `pnpm/action-setup` usage which triggered a SonarCloud security alert, and instead install it explicitly with `npm install -g pnpm@9`.
|




Agent Report Summary
backend/tests/evaluators.pytobackend/src/agent/evaluation.py, updated imports inbackend/scripts/benchmark.py, deleted accidental rootpackage-lock.jsonand added it to.gitignore.Scan Results
TODOs
Convention Enforcement
Verification
Risk Assessment
Next Steps
Machine Metadata
PR created automatically by Jules for task 4981941854204095611 started by @MasumRab
Summary by Sourcery
Consolidate agent evaluation code in the source package and align frontend dependency management and CI with pnpm.
Enhancements:
Build:
CI:
Chores: