Remove orphaned dqrobotics.solvers stub and fix stale AGENTS.md tree - #18
Merged
Merged
Conversation
After the ICRA 2019 controller moved to marinholab-sas-core (PR #17), the QP solver used by the controllers is marinholab.solvers.qpoases.Solver, and nothing in this repo imports dqrobotics.solvers anymore. That made stubs/dqrobotics/solvers/__init__.pyi (DQ_QuadraticProgrammingSolver) orphaned, violating the documented invariant that stubs declare only the symbols this project actually imports. - Delete stubs/dqrobotics/solvers/__init__.pyi. - Remove the corresponding line from the stubs tree listing in AGENTS.md. pyright reports the same (pre-existing, environment-only) missing-import warnings as before the change; no new diagnostics. Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes stale documentation and an orphaned type stub left over from the controller move (PR #17, merged).
What's stale
After PR #17 moved the ICRA 2019 task-space controller into
marinholab-sas-core, the QP solver used by the controllers is nowmarinholab.solvers.qpoases.Solver— and nothing in this repo importsdqrobotics.solversanymore. That madestubs/dqrobotics/solvers/__init__.pyi(declaringDQ_QuadraticProgrammingSolver) orphaned, violating the documented invariant (AGENTS.md) that the stub package declares only the symbols this project actually imports.Changes
stubs/dqrobotics/solvers/__init__.pyi(the orphanedDQ_QuadraticProgrammingSolverstub).solvers/__init__.pyiline from thestubs/dqrobotics/tree listing so it matches the actual tree (3 stub files:__init__.pyi,robot_modeling/,utils/).Verification
git grepconfirms no remaining references todqrobotics.solvers/DQ_QuadraticProgrammingSolveranywhere in the repo.stubs/dqrobotics/__init__.pyi(the main stub) does not reference the solvers module, so nothing else breaks.pyrightreports the same (pre-existing, environment-only)reportMissingImportswarnings for the uninstalledmarinholab-sas-coreas before this change — no new diagnostics.I scanned the full docs surface (
README.md,AGENTS.md,pyproject.toml, all docstrings) and this was the only stale item. The backward-compat alias notes forICRA19TaskSpaceControllerin the code/README are intentional (they document the alias itself), not stale.This PR was created by an AI agent (OpenHands) on behalf of the user.