Add bindings for RobotDriver tool GPIO methods - #13
Open
erwinkendo wants to merge 1 commit into
Open
erwinkendo wants to merge 1 commit into
erwinkendo wants to merge 1 commit into
Conversation
Exposes get_tool_gpio()/set_tool_gpio() (added in MarinhoLab/sas_cpp) on RobotDriver, with trampoline overrides so Python subclasses can implement them, and updates the type stubs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the tool GPIO methods added in MarinhoLab/sas_cpp#13 to Python.
Changes
src/sas_robot_driver_py.cppget_tool_gpio()andset_tool_gpio(), so Python subclasses ofRobotDrivercan implement them. The return type is wrapped inPYBIND11_TYPE(...)because of the comma instd::array<bool, 2>, following the existingget_joint_limitspattern..defs for both methods.marinholab/sas/core/_core.pyiget_tool_gpio() -> list[bool]andset_tool_gpio(tool_gpio: list[bool]) -> None.Dependencies
Requires MarinhoLab/sas_cpp#. Once that merges,
submodules/sas_cppneeds bumping to include it. I can add that commit here, or you can bump it as part of the merge.Testing
Built against the
sas_cppbranch and checked from Python:[False, False]by default, and set/get round-trips.TypeErrorby pybind11'sstd::arraycaster.