fix(packaging): dch maintainer name (DEBFULLNAME) and trailing asterisk - #7
Merged
Merged
Conversation
Follow-up to the non-interactive bump-changelog fix; the changelog
entry was being written as 'root <...>' with a stray asterisk:
- dch takes the maintainer NAME from DEBFULLNAME, not DEBNAME
(which it ignores), so the name fell back to the passwd entry of
the build user (root in the container/CI).
- NAME="${MAINTAINER%% <}*" parsed as ${MAINTAINER%% <} plus a
literal '*' (the '}' ends the expansion), appending an asterisk to
the name.
Verified in the builder image: the entry is now
'-- Murilo M Marinho <murilomarinho@ieee.org>', the bump stays
fully non-interactive (stdin closed), and re-running is a no-op.
Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Follow-up to the non-interactive
bump-changelog.shfix: the changelog entry was being written with the wrong name and a stray trailing asterisk.Problems (both in
tools/bump-changelog.sh)dchtakes the name fromDEBFULLNAME, notDEBNAME— the script setDEBNAME, whichdchsilently ignores, so the name fell back to the build user's passwd entry:(email was correct because
DEBEMAILis the right variable.)Stray
*in the name —NAME="${MAINTAINER%% <}*". The}ends the expansion, so this parses as${MAINTAINER%% <}(strip from<onward) plus a literal*, yieldingMurilo M Marinho*. (Latent: masked while the name wasroot.)Fix
DEBNAME=→DEBFULLNAME=${MAINTAINER%% <}*→${MAINTAINER%%" <"*}Verification (in
ghcr.io/marinholab/gazebo:jazzy, the real builder base image)After the fix, a fresh clone of
main+bash tools/bump-changelog.sh(stdin closed, CI-like):debian/controlMaintainer:fieldChangelog already at 26.09.07.Full pipeline (bump →
dpkg-buildpackage→dpkg -i→find_packageconsumer probe) confirmed green in the same image in the preceding integration test.This pull request was created by an AI agent (OpenHands) on behalf of the repository owner.