Repository navigation
chore(release): bump version to 0.5.0 - #528
Conversation
MarcosACH
left a comment
There was a problem hiding this comment.
Review of ralph/issue-527 @ b84ed1b
Reviewer: code-review skill
Reviewed: 2026-10-17
Optimization axis: correctness (the release record)
Mechanical
- ruff format: pass
- ruff check: pass
- mypy: pass
- lint-imports: pass (7 kept, 0 broken)
- pytest: pass (2185 passed, 75 skipped, coverage 97.58%)
The version bump is right. pyproject.toml and uv.lock both say 0.5.0, and tickwright.__version__ reads 0.5.0 after sync. MINOR is the right lane. Every seam claim in the entry matches src/tickwright/domain/protocols.py since v0.4.0. All 19 sub-issues of PRD #457 are closed, including the integrate-and-verify slice #476.
Findings
[WARN] R001 — docs/workflow/versioning.md:99 — History entry leaves out two contract changes
Category: docs
Why: Issue #527 lists them, but the entry does not. Config now refuses __operator__ and __unattributed__ as a strategy_id (ADR-0054). That can make a config that booted on 0.4.0 refuse to boot. The CLI also gained --new-store (ADR-0052). Both are part of the versioned public API. A Hyperliquid MARKET order is now also capped by the mark, and it ends FAILED with no mark cached (ADR-0059, #509).
Fix: Add one or two sentences to the entry. Name the reserved strategy ids, the --new-store flag, and the mark cap on MARKET orders.
Status: open
[WARN] R002 — docs/workflow/versioning.md:103 — Fixes list misses two crash fixes and has no issue numbers for the margin fixes
Category: docs
Why: Two fixes since v0.4.0 stopped the engine from crashing: #509 (market order before the first mark on Hyperliquid) and #513 (LIMIT with no price). Neither is listed. #515 (made-up liquidation price at boot) is missing too. "The live isolated margin readings" cites no issue, but it covers #516, #518, #520, and #522. Every earlier entry cites its fixes by number.
Fix: Add #509, #513, and #515 to the fixes. Give the margin fixes their issue numbers (#516, #518, #520, #522).
Status: open
Summary
- BLOCKING: 0 open
- WARN: 2 open
- NIT: 0 open
- Merge: BLOCKED
Ralph-State: changes-requested
…notes The entry left out the reserved strategy ids, the --new-store flag, and the mark cap on market orders. It also missed three fixes and gave the margin fixes no issue numbers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MarcosACH
left a comment
There was a problem hiding this comment.
Review of ralph/issue-527 @ 448adaf
Reviewer: code-review skill
Reviewed: 2026-10-17
Optimization axis: correctness (the release record)
Mechanical
- ruff format: pass
- ruff check: pass
- mypy: pass
- lint-imports: pass (7 kept, 0 broken)
- pytest: pass (2185 passed, 75 skipped, coverage gate 90% met)
Both earlier findings are fixed at 448adaf. The cited issue numbers are all closed and match their claims. #467 is the right issue for the mark cap.
Findings
[WARN] R001 — docs/workflow/versioning.md:99 — History entry leaves out two contract changes
Category: docs
Status: resolved — 448adaf (verified)
[WARN] R002 — docs/workflow/versioning.md:103 — Fixes list misses two crash fixes and has no issue numbers for the margin fixes
Category: docs
Status: resolved — 448adaf (verified)
[WARN] R003 — docs/workflow/versioning.md:106 — Fixes list still misses the paper restart fix (#484)
Category: docs
Why: On v0.4.0, paper forgot its resting orders on restart, and reconcile ghosted them later. #484 fixed that, and an operator on paper will see the change. The entry claims every fix but does not list it.
Fix: Add one sentence to the fixes, for example: "Paper keeps its resting orders across a restart (#484)."
Status: open
Summary
- BLOCKING: 0 open
- WARN: 1 open
- NIT: 0 open
- Merge: BLOCKED
Ralph-State: changes-requested
On v0.4.0, paper forgot its resting orders after a restart. #484 fixed that, and the entry did not say so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MarcosACH
left a comment
There was a problem hiding this comment.
Review of ralph/issue-527 @ 6b89656
Reviewer: code-review skill
Reviewed: 2026-10-17
Optimization axis: correctness (the release record)
Mechanical
- ruff format: pass
- ruff check: pass
- mypy: pass
- lint-imports: pass (7 kept, 0 broken)
- pytest: pass (2185 passed, 75 skipped, coverage 98%)
R003 is fixed at 6b89656. #484 is closed and matches the sentence. I checked every fix commit since v0.4.0 against the entry. Each one is listed, or it fixes a feature that is new in this release, such as flatten (#503) and reduce-only (#493).
Findings
[WARN] R001 — docs/workflow/versioning.md:99 — History entry leaves out two contract changes
Category: docs
Status: resolved — 448adaf (verified)
[WARN] R002 — docs/workflow/versioning.md:103 — Fixes list misses two crash fixes and has no issue numbers for the margin fixes
Category: docs
Status: resolved — 448adaf (verified)
[WARN] R003 — docs/workflow/versioning.md:106 — Fixes list still misses the paper restart fix (#484)
Category: docs
Status: resolved — 6b89656 (verified)
Summary
- BLOCKING: 0 open
- WARN: 0 open
- NIT: 0 open
- Merge: READY
Ralph-State: ready
PRD #457 (safe exit on real money) is delivered, but nothing has shipped since
v0.4.0on 2026-09-27. All of it sits untagged.This PR moves
pyproject.tomlfrom0.4.0to0.5.0and re-locksuv.lock. It adds thev0.5.0entry under## Historyindocs/workflow/versioning.md.Why MINOR: the
0.xrules put feature work and contract changes in the MINOR lane.Exchange.cancel(ref)becamecancel(refs), andExchangegained two reads. So a third-party adapter must change.MarketFeedandStoregained members too. The CLI gainedcancel-all,flatten, and--new-store.After merge: run
ci-liveon the merge commit, tagv0.5.0, cut the GitHub Release, and close PRD #457 with the release URL.Closes #527
🤖 Generated with Claude Code