Use class instead of param for state in authorization and end-session requests #653
Open
pcba-dev wants to merge 2 commits into
Open
Use class instead of param for state in authorization and end-session requests #653pcba-dev wants to merge 2 commits into
pcba-dev wants to merge 2 commits into
Conversation
…-session requests
…e and endSession methods
pcba-dev
force-pushed
the
use-class-instead-of-param-for-state
branch
from
f4f962e to
18e6ded
Compare
MaikuB
requested changes
May 23, 2026
Owner
MaikuB
left a comment
MaikuB
left a comment
There was a problem hiding this comment.
Thanks for the updated PR. Besides the linter issue, there are a couple of issues I picked up with the PR so far
- This file needs to be updated to expose the new classes. This is necessary to make it so that developers only need to import a reference the main plugin access the new classes
- Once done, can you test all of the possible permutations on all platforms? I did a test and saw an exception when triggering an end session request with null state (i.e. used the
SuppressedStateclass). This occurred on iOS and looks like further changes would be needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #646 based on #647 (review)