Terminate rejected target_session_attrs candidates before returning - #1380
Merged
Merged
Conversation
With `target_session_attrs`, `connect()` opens candidate connections in turn until one has the requested attribute. Rejected candidates used to be closed in a detached task. That task could outlive the caller's event loop, producing "Event loop is closed" errors and pending-task warnings, and leaving the connections open. Now every candidate that is not returned is terminated before `connect()` exits, whether the attribute check matched, did not match, raised, or was cancelled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
target_session_attrs,connect()opens candidate connections inturn until one has the requested attribute. Rejected candidates used to
be closed in a detached task. That task could outlive the caller's event
loop, producing "Event loop is closed" errors and pending-task warnings,
and leaving the connections open.
Now every candidate that is not returned is terminated before
connect()exits, whether the attribute check matched, did not match,raised, or was cancelled.