Repository navigation
docs: add PR template and contribution guidelines - #600
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
Link it from the PR template and DEVELOPMENT.md. The template also gains a Testing section and a scope checkbox. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
…template Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
… small changes Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
CI covers automated tests; only device or platform-specific changes need manual test notes, which now live in the Changes and impact hint. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Loong · project thread
动机 / Motivation
仓库没有 PR 模板,也没有写明对贡献的约定。随着 AI 工具普及,PR 的规模和数量都在增加,维护者 review 的负担也随之加重。需要一个地方写明约定,让贡献者提交前知道我们的期望,也让维护者在 review 时有据可依。
方案 / Solution
CONTRIBUTING.md:中英文分节,列出 5 条约定(大改动先在 issue 讨论方案、一个 PR 只做一件事、欢迎使用 AI 但需作者本人审阅、描述简洁、用自己的话回复 review),以及不符合约定时的处理方式。规则编号,方便 review 时引用。修 bug、文档和小改进不受「先开 issue」约束。.github/pull_request_template.md:中英双语的「动机 / 方案 / 变更与影响」三节、两条检查项(只含必要改动、同步多语言文档)和「AI 辅助」一节(未使用 AI,或已亲自审阅 AI 生成的改动二选一)。自动化测试由 CI 覆盖,不单设验证一节;只有涉及设备连接或平台相关的改动,才需要在「变更与影响」中说明实测情况。小改动只需填写动机。AGENTS.md:新增给 agent 的贡献规则,比如没有已认可的设计时先停下、在人看完 diff 前不开 PR、不替人勾自审检查项、不代写 review 回复。agent 会自动读 AGENTS.md,但不一定会打开 CONTRIBUTING。DEVELOPMENT.md:注意事项里加上 CONTRIBUTING 的链接。.github/.markdownlint.yaml:继承根目录配置,对.github/下的文件关闭 MD041(首行必须是一级标题),因为模板不以一级标题开头。不确定的地方:「约 500 行」和「review 后 30 天无回应」这两个数字是经验值,可以再调整。
变更与影响 / Changes and impact
新开的 PR 会自动带上模板,GitHub 也会在开 PR 时提示 CONTRIBUTING。代码没有改动。
检查项 / Checklist
crates/maa-cli/docs/下所有语言的文档 / User-visible behavior changed: docs undercrates/maa-cli/docs/are updated for every language(不涉及 / N/A)AI 辅助 / AI assistance
🤖 Generated with Claude Code
https://claude.ai/code/session_01Qi8EYMmsuJP5a8dihMu6rA
Sourcery 总结
统一人类和 AI 辅助贡献的贡献规范与拉取请求准备要求。
新功能:
改进:
构建:
文档:
Original summary in English
Sourcery 摘要
为人工贡献和 AI 辅助贡献制定清晰的双语贡献规范与 PR 准备指南。
新功能:
增强:
构建:
文档:
Original summary in English
Summary by Sourcery
Establish clear bilingual contribution standards and PR preparation guidance for both human and AI-assisted contributions.
New Features:
Enhancements:
Build:
Documentation: