Skip to content

fix(tutorial): keep input bar mounted and focused during command entry #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nschimme merged 1 commit into from
Sep 21, 2026
Merged

fix(tutorial): keep input bar mounted and focused during command entry #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 15 additions & 18 deletions docs/.vitepress/theme/components/TutorialPlayer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,23 +789,10 @@ onUnmounted(() => {

<div class="tut-prompt"
:class="{
'is-pager': isScrollOverflowActive && !isScrolling && !entry,
'is-complete': playerState === PlayerState.CHAPTER_COMPLETE
}">
<!-- Mode 1: Paging State (Replaces input box with interactive pill button) -->
<button v-if="isScrollOverflowActive && !isScrolling && !entry"
type="button"
class="tut-full-pager-btn"
@click.prevent="pageForward(true)"
@keydown.enter.prevent="pageForward(true)"
@keydown.space.prevent="pageForward(true)"
aria-label="Scroll to read more output">
<i class="fa fa-chevron-circle-down tut-toast-icon" aria-hidden="true"></i>
<span>{{ toastText }}</span>
</button>

<!-- Mode 2: Chapter Completion State (Replaces input box with full-width completion pill button) -->
<button v-else-if="playerState === PlayerState.CHAPTER_COMPLETE"
<!-- Mode 1: Chapter Completion State (Replaces input box with full-width completion pill button) -->
<button v-if="playerState === PlayerState.CHAPTER_COMPLETE"
type="button"
class="tut-full-complete-btn"
@click.stop="submit()"
Expand All @@ -816,8 +803,19 @@ onUnmounted(() => {
<i class="fa fa-arrow-right tut-complete-icon" aria-hidden="true"></i>
</button>

<!-- Mode 3: Normal Command Input Bar -->
<!-- Mode 2: Normal Command Input Bar with Non-Blocking Floating Overflow Toast -->
<template v-else>
<Transition name="tut-toast-fade">
<button v-if="isScrollOverflowActive && !isScrolling"
type="button"
class="tut-pager-toast"
@click.prevent="pageForward(true)"
aria-label="Scroll to read more output">
<i class="fa fa-chevron-circle-down tut-toast-icon" aria-hidden="true"></i>
<span>{{ toastText }}</span>
</button>
</Transition>

<span class="tut-caret">&gt;</span>
<input ref="inputEl" v-model="entry" @keydown.enter.prevent="submit"
autocomplete="off" spellcheck="false"
Expand Down Expand Up @@ -1377,8 +1375,7 @@ onUnmounted(() => {
.tut-secondary-link:hover, .tut-secondary-link:focus-visible { background: darkgoldenrod; color: #3a3a3a !important; text-decoration: none !important; }
.tut-note { color: #8f8a7d; font-size: 12.5px; margin: 4px 0 6px; }

.tut-prompt { display: flex; align-items: center; gap: 8px; border-top: 1px solid #23262e; padding: 10px 14px; background: #08080a; transition: background 0.25s, border-color 0.25s; }
.tut-prompt.is-pager { background: linear-gradient(180deg, #1a160a, #0b0c0f); border-top-color: rgba(255, 215, 0, 0.6); padding: 8px 12px; }
.tut-prompt { display: flex; align-items: center; gap: 8px; border-top: 1px solid #23262e; padding: 10px 14px; background: #08080a; transition: background 0.25s, border-color 0.25s; position: relative; }

/* Full-width Pager Action Pill Button */
.tut-full-pager-btn {
Expand Down
13 changes: 10 additions & 3 deletions tests/tutorial_player.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,18 @@ describe('TutorialPlayer.vue', () => {
expect(backBtn.exists()).toBe(true)
})

it('sets input readonly when pager mode is active', async () => {
it('keeps input element mounted and accessible during quest steps', async () => {
const wrapper = mount(TutorialPlayer)
// Initially not readonly when input is empty and no overflow
const input = wrapper.find('input')
expect(input.attributes('readonly')).toBeUndefined()
expect(input.exists()).toBe(true)

// Submit first command
await input.setValue('score')
await input.trigger('keydown.enter')

// Verify input remains mounted and accessible for subsequent commands (e.g. info or exits)
const inputAfter = wrapper.find('input')
expect(inputAfter.exists()).toBe(true)
})

it('provides helpful error text for unrecognized commands', async () => {
Expand Down
Loading