feat(JwtBearer): empty-JWKS detection + periodic authority re-validation - #5
Merged
Merged
Conversation
added 2 commits
September 10, 2026 12:58
… authority re-validation (PeriodicValidationInterval)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the two most-complete options requested to close the remaining gaps for SafeWebCore.JwtBearer:
Empty-JWKS detection — a discovery document that loads but contains no signing keys is now a permanent configuration error: Error log + startup throw when
FailFast, down-gradable to a Warning viaRequireSigningKeys = false. Covers the misconfiguration where the IdP responds 200 but provides no keys (every token would otherwise fail with "no signing keys").Periodic re-validation — optional
PeriodicValidationIntervalruns a background timer that re-probes the metadata endpoint while the app runs. It never throws (a running server is never killed): permanent (4xx) failures log at Error, transient at Warning. This closes the last-known-good observability gap: IdentityModel otherwise serves the cached metadata without throwing, so an IdP outage after a healthy start stays invisible.Guard refactored (
ValidateAuthorityAsync/ReportConfigurationResult/ReportMetadataFailure) and madeIDisposable(CancellationTokenSource lifecycle).Verification
dotnet build SafeWebCore.slnx -c Release— 0 warnings / 0 errorsdotnet test SafeWebCore.slnx -c Release— 168/168 passed (38 JwtBearer tests, +5 new)SonarCloud analysis on this PR will run automatically; fixes applied until the Quality Gate is green, then merge.