Skip to content

Fix height.sql COALESCE using h1 for both args instead of h1/h2 #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chessing234 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −9
Open

Fix height.sql COALESCE using h1 for both args instead of h1/h2 #1985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mimic-iv/concepts/measurement/height.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ WITH ht_in AS (
-- merge cm/height, only take 1 value per charted row
, ht_stg0 AS (
SELECT
COALESCE(h1.subject_id, h1.subject_id) AS subject_id
, COALESCE(h1.stay_id, h1.stay_id) AS stay_id
, COALESCE(h1.charttime, h1.charttime) AS charttime
COALESCE(h1.subject_id, h2.subject_id) AS subject_id
, COALESCE(h1.stay_id, h2.stay_id) AS stay_id
, COALESCE(h1.charttime, h2.charttime) AS charttime
, COALESCE(h1.height, h2.height) AS height
FROM ht_cm h1
FULL OUTER JOIN ht_in h2
Expand Down
6 changes: 3 additions & 3 deletions mimic-iv/concepts_duckdb/measurement/height.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ WITH ht_in AS (
NOT c.valuenum IS NULL AND c.itemid = 226730
), ht_stg0 AS (
SELECT
COALESCE(h1.subject_id, h1.subject_id) AS subject_id,
COALESCE(h1.stay_id, h1.stay_id) AS stay_id,
COALESCE(h1.charttime, h1.charttime) AS charttime,
COALESCE(h1.subject_id, h2.subject_id) AS subject_id,
COALESCE(h1.stay_id, h2.stay_id) AS stay_id,
COALESCE(h1.charttime, h2.charttime) AS charttime,
COALESCE(h1.height, h2.height) AS height
FROM ht_cm AS h1
FULL OUTER JOIN ht_in AS h2
Expand Down
6 changes: 3 additions & 3 deletions mimic-iv/concepts_postgres/measurement/height.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ WITH ht_in AS (
NOT c.valuenum IS NULL AND /* Height cm */ c.itemid = 226730
), ht_stg0 AS (
SELECT
COALESCE(h1.subject_id, h1.subject_id) AS subject_id,
COALESCE(h1.stay_id, h1.stay_id) AS stay_id,
COALESCE(h1.charttime, h1.charttime) AS charttime,
COALESCE(h1.subject_id, h2.subject_id) AS subject_id,
COALESCE(h1.stay_id, h2.stay_id) AS stay_id,
COALESCE(h1.charttime, h2.charttime) AS charttime,
COALESCE(h1.height, h2.height) AS height
FROM ht_cm AS h1
FULL OUTER JOIN ht_in AS h2
Expand Down