Repository navigation
Explore: exact totals for events, attributes and correlations - #508
Merged
Merged
Conversation
OpenSearch counts hits up to 10,000 unless asked for the exact total, so Explore's events, attributes and correlations tabs stopped at 10000 while indicators (which already asked) showed the real count. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OpenAPI changesNo changes to the OpenAPI spec. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
=======================================
Coverage 88.74% 88.74%
=======================================
Files 295 295
Lines 35114 35114
=======================================
Hits 31163 31163
Misses 3951 3951 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Explore's Events, Attributes and Correlations tabs never showed more than 10,000 matches. OpenSearch only counts hits up to 10,000 unless a search asks for the exact total. The Indicators tab already asked for it, so it showed the real count.
Change
The event, attribute and correlation searches set
track_total_hits: True. That's one line in each ofsearch_events,search_attributesandsearch_correlations.On a dev instance with 453,626 attributes and 44,612 correlations, both tabs now show those totals where they previously showed 10,000. Events also show their exact total (1,913 here).
Counting every match makes searches with more than 10,000 hits slightly slower; the indicators search already pays this cost.
🤖 Generated with Claude Code