prevent unnecessary keyError in add_attribute - #1461
Open
mahdishirvani79 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
add_attribute()with a list of attributes where every attribute is invalid (for example, due to a type mismatch),_check_json_response()returns a dictionary containing only an errors key and no Attribute key.When
pythonify=True, the code assumes the Attribute key is always present and iterates overnew_attribute['Attribute'], which raises aKeyErrorin this case.This change replaces direct indexing with
new_attribute.get('Attribute', []), allowing the method to handle error-only responses gracefully while preserving the existing behaviour for successful responses.