Skip to content

Fix LAMMPS DCD writer compatibility with base tests - #5542

Open
nayansharma8123-gif wants to merge 8 commits into
MDAnalysis:developfrom
nayansharma8123-gif:tests/lammps-base-reader-writer
Open

nayansharma8123-gif wants to merge 8 commits into
MDAnalysis:developfrom
nayansharma8123-gif:tests/lammps-base-reader-writer

Conversation

@nayansharma8123-gif

Copy link
Copy Markdown

Part of [#516]

Changes made in this Pull Request

  • Added LAMMPSDCDReference to provide the reference data required by the shared reader and writer tests.
  • Migrated LAMMPS DCD reader tests to use BaseReaderTest.
  • Migrated LAMMPS DCD writer tests to use BaseWriterTest.
  • Added a DCDReader.Writer() override to preserve the correct LAMMPS time-step conversion when writing DCD trajectories.
  • Updated shared writer tests to use the reader's Writer() method and the appropriate atom count.
  • Added my name to package/AUTHORS.

Testing

  • Coordinate test suite: 2,637 passed, 444 skipped, 6 xfailed.
  • git diff --check passed.

LLM / AI-generated code disclosure

LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: yes.

I used AI tools for guidance while working on this contribution, mainly to understand the codebase and troubleshoot issues. The implementation, changes, and test results were reviewed and verified by me.

PR Checklist

Developers Certificate of Origin

I certify that I can submit this code contribution as described in the [Developer Certificate of Origin](https://developercertificate.org/), under the MDAnalysis [LICENSE](https://github.com/MDAnalysis/mdanalysis/blob/develop/LICENSE).

@read-the-docs-community

read-the-docs-community Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.92%. Comparing base (ae9ff4b) to head (60f6c83).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5542   +/-   ##
========================================
  Coverage    93.92%   93.92%           
========================================
  Files          184      184           
  Lines        22661    22666    +5     
  Branches      3223     3224    +1     
========================================
+ Hits         21284    21290    +6     
+ Misses         917      916    -1     
  Partials       460      460           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant