Repository navigation
Morojs tls 1.8.21 - #1713
Open
M-Chris wants to merge 4 commits into
Open
Morojs tls 1.8.21#1713M-Chris wants to merge 4 commits into
M-Chris wants to merge 4 commits into
Conversation
…own BIOs The three TLS profiles were the entry's whole HTTP/1.1 deficit: json-tls 569 and 8gbit 771 of a thousand against 749 and 869 for the leading uWebSockets.js entries, with every plaintext profile led or tied. @morojs/engine 1.1.17 terminates TLS on its own BIOs instead of BIO_s_mem pairs: the read side is a view over the transport's buffer (one copy in, where the memory BIO added a second), the write side appends ciphertext straight into the buffer the transport sends from (the memory BIO grew by copying, was copied out of, and zeroed its capacity on every reset), and a body over 8 KiB is encrypted from the caller's bytes rather than copied behind the head first. The ciphertext scratch is kept between replies, so a static file's worth of pages is no longer faulted in and zeroed per reply. MoroJS 1.8.21 revalidates a cached static file once per window instead of once per request crossing it: at 1024 keep-alive connections the old behaviour stat'ed the file and both sidecar positions on the threadpool for every request that crossed the second. Measured at one worker, same machine, CPU per request from the cgroup: the static-tls mix 39 us to 28, the json-tls mix 22.5 to 19, the 8gbit echo 150 to 127; the leading uWebSockets.js entry measures 28-32, 19-20 and 132 on the same rig. The dependency floor moves to 1.8.21 so a build never measures the older path by resolving a cached package.
M-Chris
requested review from
Kaliumhexacyanoferrat and
MDA2AV
as code owners
November 5, 2026 18:15
Contributor
Author
|
/benchmark -f morojs -t json-tls,8gbit,static-tls --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
|
|
Contributor
Author
|
/benchmark -f morojs -t json-tls,8gbit,static-tls --save |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Composite score, main against this run, in the board's default view:
The results on main were measured in another session, so a few points up or down can be the machine and not the change. Full log |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR Commands — comment on this PR to trigger (requires collaborator approval):
/benchmark -f <framework>/benchmark -f <framework> -t <test>/benchmark -f <framework> -t <t1>,<t2>,.../benchmark -f <framework> --save/benchmark -f <framework> -t <test> --save/benchmark -f <framework> --compare <other>/benchmark-multiple -f <fw1>,<fw2>,...-tand--savetoo; saved results land in a single commit/benchmark-multiple --save-fneeded: benchmark and save every framework the PR touches/benchmark-test -t <test><test>and save the resultsFor
/benchmark, always specify-f <framework>; the flags combine in any order. Results come back as a comment with a per-profile table of RPS, p99, CPU and memory — one table per framework on multi runs. A new benchmark comment while a run is in flight queues behind it (one deep) instead of cancelling it. For multi-framework PRs (dependency bumps, same-language refactors) prefer/benchmark-multiple, which runs everything in a single job and commits all saved results together, so no run overwrites another.--compareworks on single-framework runs only.What the deltas are measured against. By default, this framework's own results published on
main- answering "did this change help?". When you are tuning a variant or a successor entry,--comparere-bases them on another entry instead:The reply states which baseline it used, and profiles the other framework does not run show
n/arather than a delta.Run benchmarks locally
You can validate and benchmark your framework locally with the lite script — no CPU pinning, fixed connection counts, all load generators run in Docker.
Requirements: Docker Engine on Linux. Load generators (gcannon, h2load, h2load-h3, wrk) are built as self-contained Docker images on first run.