Repository navigation
Framework variants: two entries of one framework side by side - #1712
Open
nigrosimone wants to merge 3 commits into
Open
nigrosimone wants to merge 3 commits into
nigrosimone wants to merge 3 commits into
Conversation
nigrosimone
marked this pull request as ready for review
November 5, 2026 18:11
nigrosimone
requested review from
Kaliumhexacyanoferrat and
MDA2AV
as code owners
November 5, 2026 18:11
Collaborator
|
I feel „default_visible“ should be false if not explicitely specified 🤔 Otherwise we will probably see all the variants on top. I would start defensively here - we can change the default later at any time. |
Contributor
Author
|
Good point, done. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #1709. Two entries of one framework, like
hono-nodeandhono-bun, are unrelated rows on the board today. This adds variants: same framework, another runtime or documented API. All variants are legitimate and it is separate frommode.frameworkandvariantin meta.json.scripts/check_variants.pyallows at most two per framework, in its own small workflow."default_visible": true.hono-nodeandhono-bunare the first two variants.A hidden variant still counts for the leader of each profile, like a tuned entry that is filtered out. I left out
?variant=for badges: each entry has already its own URL.Tested with hono-bun hidden:
check_badge_parity.jspasses and fails without the change inbadge_composite, the board in headless Chrome hides and shows the row with the filter,check_variants.pyrefuses the five wrong cases.