Skip to content

Read the method of a visit before the lambda takes the headers #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kaliumhexacyanoferrat merged 1 commit into from
Oct 13, 2026
Merged

Read the method of a visit before the lambda takes the headers #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/GenHTTP.Lambda/Services/Visits/LambdaVisitConcern.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ public sealed class LambdaVisitConcern : IDependentConcern

var hints = counted ? HintsOf(headers) : null;

var method = request.Header.Method;

var started = Stopwatch.GetTimestamp();

IResponse? response = null;
Expand All @@ -87,7 +89,7 @@ public sealed class LambdaVisitConcern : IDependentConcern

request.SetVisit(new LambdaVisit(lambda, DateTime.UtcNow, path, domain, status, Stopwatch.GetElapsedTime(started),
(long)(response?.Content?.Length ?? 0), caller?.Client, caller?.Agent, caller?.Country,
referrer, counted && IsPage(request, status, destination, response), hints));
referrer, counted && IsPage(method, status, destination, response), hints));
}
}

Expand Down Expand Up @@ -132,9 +134,9 @@ private static string PathOf(IRequest request)
/// they got back was HTML. A redirect is not a page: the page it sends to
/// is counted when it is opened.
/// </remarks>
private static bool IsPage(IRequest request, int status, string? destination, IResponse? response)
private static bool IsPage(RequestMethod method, int status, string? destination, IResponse? response)
{
if (request.Header.Method != RequestMethod.Get || status is not (>= 200 and < 300 or 304))
if (method != RequestMethod.Get || status is not (>= 200 and < 300 or 304))
{
return false;
}
Expand Down
Loading