Repository navigation
Group the analytics cards by what they count - #116
Merged
Merged
Conversation
The cards counted page views, the crawlers' card requests, side by side without saying so - a lambda with 79 requests showed 13 devices next to 50 crawler visits, which read as figures that did not add up. They are now two groups under the names of the figures at the top: page views (pages, sites, countries, devices, browsers, systems) and requests (what was requested by path, crawlers). Devices joined the browsers and systems as a third pill, so the groups pair up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014qQBMy3YGyxKt7EzfanaSK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The analytics cards counted page views where a lambda has any, but the crawlers' card always counted requests - side by side, without saying so. A lambda with 79 requests showed 13 devices next to 50 crawler visits, which read as figures that did not add up (they did: 13 page views, 51 requests).
The cards are now in two groups, headed by the names and hints of the figures at the top:
A lambda without pages people open has the requests group only, as before. No new strings: the headings reuse the figures' translated words. The decision is in CLAUDE.md, the behaviour in the README.
No "Unknown" device row: every request is counted under a device, so within a group the devices add up to the total exactly.
Checked against the live figures of genhttp.org (dev server proxied to genhttp.dev), light, dark and phone;
npm run buildpasses.🤖 Generated with Claude Code
https://claude.ai/code/session_014qQBMy3YGyxKt7EzfanaSK