Skip to content

fix: decode painting variant item components #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milutinke merged 1 commit into from
Sep 30, 2026
Merged

fix: decode painting variant item components #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions engineering/testcounts/expected_counts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
"Umpk.Data.Lang.Tests.dll": 80,
"Umpk.DataGen.Tests.dll": 67,
"Umpk.Game.Tests.dll": 484,
"Umpk.IntegrationTests.dll": 46,
"Umpk.IntegrationTests.dll": 47,
"Umpk.Nbt.Tests.dll": 118,
"Umpk.PacketRecorder.Tests.dll": 14,
"Umpk.Pathfinding.Tests.dll": 1045,
"Umpk.Physics.Tests.dll": 292,
"Umpk.Protocol.Java.Conformance.dll": 881,
"Umpk.Protocol.Java.Tests.dll": 4670,
"Umpk.Protocol.Java.Tests.dll": 4688,
"Umpk.Realms.Tests.dll": 53,
"Umpk.Text.Tests.dll": 218
}
22 changes: 11 additions & 11 deletions fixtures/codec-identity/770.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ Play Clientbound 0x0E minecraft:clear_titles TitleCodecs.ClearTitlesV1_17 read:1
Play Clientbound 0x0F minecraft:command_suggestions CommandSuggestionCodecs.CommandSuggestionsV1_20_3 read:4 shape:opaque
Play Clientbound 0x10 minecraft:commands CommandTreeCodecs.V1_21_5 fault:ProtocolViolationException shape:varint*node,varint|argtypes/940a0fa5,timemin=1
Play Clientbound 0x11 minecraft:container_close ContainerCodecs.ContainerCloseClientModern read:1 shape:opaque
Play Clientbound 0x12 minecraft:container_set_content MakeContainerSetContent(Table770) read:4 shape:varint,varint,varint*stack,stack|components/3e625a95
Play Clientbound 0x12 minecraft:container_set_content MakeContainerSetContent(Table770) read:4 shape:varint,varint,varint*stack,stack|components/0995b74c
Play Clientbound 0x13 minecraft:container_set_data ContainerCodecs.ContainerSetDataModern read:5 shape:opaque
Play Clientbound 0x14 minecraft:container_set_slot MakeContainerSetSlot(Table770) read:5 shape:varint,varint,short,stack|components/3e625a95
Play Clientbound 0x14 minecraft:container_set_slot MakeContainerSetSlot(Table770) read:5 shape:varint,varint,short,stack|components/0995b74c
Play Clientbound 0x15 minecraft:cookie_request PlayCommonCodecs.CookieRequest fault:FormatException shape:identifier
Play Clientbound 0x16 minecraft:cooldown UiMiscCodecs.CooldownV1_21_2 fault:FormatException shape:opaque
Play Clientbound 0x17 minecraft:custom_chat_completions ChatDisplayCodecs.CustomChatCompletionsV1_19_1 read:2 shape:opaque
Expand All @@ -82,11 +82,11 @@ Play Clientbound 0x25 minecraft:initialize_border WorldBorderCodecs.InitializeBo
Play Clientbound 0x26 minecraft:keep_alive PlayKeepAliveCodecs.ClientV1_12_2 read:8 shape:long
Play Clientbound 0x27 minecraft:level_chunk_with_light ChunkCodecs.V1_21_5 read:256 shape:chunk_modern(FixedSize,fluid=0,biome=1,min=6)
Play Clientbound 0x28 minecraft:level_event WorldEffectCodecs.LevelEventV1_14 read:17 shape:opaque
Play Clientbound 0x29 minecraft:level_particles WorldEffectCodecs.LevelParticlesV1_21_5 read:47 shape:level_particles_modern(shapes=b2aecf14,icons=components/3e625a95,alwaysshow=1)
Play Clientbound 0x29 minecraft:level_particles WorldEffectCodecs.LevelParticlesV1_21_5 read:47 shape:level_particles_modern(shapes=b2aecf14,icons=components/0995b74c,alwaysshow=1)
Play Clientbound 0x2A minecraft:light_update WorldStateCodecs.LightUpdateV1_20 read:8 shape:opaque
Play Clientbound 0x2B minecraft:login JoinGameCodecs.V1_21_2 read:30 shape:join_game(legacy=0,onlinemode=0)
Play Clientbound 0x2C minecraft:map_item_data WorldMapCodecs.MapItemDataV1_21_5 read:5 shape:varint,byte,bool,opt(varint*icon),patch|nbt/modern
Play Clientbound 0x2D minecraft:merchant_offers MakeMerchantOffers(Table770) read:6 shape:varint,varint*offer,varint,varint,bool,bool|components/3e625a95
Play Clientbound 0x2D minecraft:merchant_offers MakeMerchantOffers(Table770) read:6 shape:varint,varint*offer,varint,varint,bool,bool|components/0995b74c
Play Clientbound 0x2E minecraft:move_entity_pos EntityMoveCodecs.MoveEntityPosV1_9 read:8 shape:opaque
Play Clientbound 0x2F minecraft:move_entity_pos_rot EntityMoveCodecs.MoveEntityPosRotV1_9 read:10 shape:opaque
Play Clientbound 0x30 minecraft:move_minecart_along_track marker n/a shape:opaque
Expand All @@ -108,7 +108,7 @@ Play Clientbound 0x3F minecraft:player_info_update PlayerListCodecs.PlayerInfoUp
Play Clientbound 0x40 minecraft:player_look_at marker n/a shape:opaque
Play Clientbound 0x41 minecraft:player_position EntityMoveCodecs.PlayerPositionV1_21_2 read:61 shape:opaque
Play Clientbound 0x42 minecraft:player_rotation marker n/a shape:opaque
Play Clientbound 0x43 minecraft:recipe_book_add RecipeCodecs.RecipeBookAdd(RecipeBookWire.V1_21_5(Table770)) read:2 shape:recipe_book_add(slots=Empty+AnyFuel+Item+ItemStack+Tag+SmithingTrim+WithRemainder+Composite,trimholder=1,stacks=countfirst/components/3e625a95)
Play Clientbound 0x43 minecraft:recipe_book_add RecipeCodecs.RecipeBookAdd(RecipeBookWire.V1_21_5(Table770)) read:2 shape:recipe_book_add(slots=Empty+AnyFuel+Item+ItemStack+Tag+SmithingTrim+WithRemainder+Composite,trimholder=1,stacks=countfirst/components/0995b74c)
Play Clientbound 0x44 minecraft:recipe_book_remove RecipeCodecs.RecipeBookRemoveModern read:1 shape:opaque
Play Clientbound 0x45 minecraft:recipe_book_settings RecipeCodecs.RecipeBookSettingsModern read:8 shape:opaque
Play Clientbound 0x46 minecraft:remove_entities EntitySpawnCodecs.RemoveEntities read:1 shape:opaque
Expand All @@ -130,10 +130,10 @@ Play Clientbound 0x55 minecraft:set_border_warning_distance WorldBorderCodecs.Se
Play Clientbound 0x56 minecraft:set_camera EntityStateCodecs.SetCamera read:1 shape:opaque
Play Clientbound 0x57 minecraft:set_chunk_cache_center WorldStateCodecs.SetChunkCacheCenterV1_14 read:2 shape:opaque
Play Clientbound 0x58 minecraft:set_chunk_cache_radius WorldStateCodecs.SetChunkCacheRadiusV1_14 read:1 shape:opaque
Play Clientbound 0x59 minecraft:set_cursor_item MakeSetCursorItem(Table770) read:1 shape:stack|components/3e625a95
Play Clientbound 0x59 minecraft:set_cursor_item MakeSetCursorItem(Table770) read:1 shape:stack|components/0995b74c
Play Clientbound 0x5A minecraft:set_default_spawn_position WorldStateCodecs.SetDefaultSpawnV1_17 read:12 shape:opaque
Play Clientbound 0x5B minecraft:set_display_objective ScoreboardCodecs.SetDisplayObjectiveV1_20_2 read:2 shape:opaque
Play Clientbound 0x5C minecraft:set_entity_data EntityDataCodecs.SetEntityDataV1_21_5 fault:ProtocolViolationException shape:varint,metadata|metadata/59245ff2,Modern,countfirst/components/3e625a95,particles=components/3e625a95
Play Clientbound 0x5C minecraft:set_entity_data EntityDataCodecs.SetEntityDataV1_21_5 fault:ProtocolViolationException shape:varint,metadata|metadata/59245ff2,Modern,countfirst/components/0995b74c,particles=components/0995b74c
Play Clientbound 0x5D minecraft:set_entity_link EntityStateCodecs.SetEntityLinkV1_9 read:8 shape:opaque
Play Clientbound 0x5E minecraft:set_entity_motion EntityMoveCodecs.SetEntityMotion read:7 shape:opaque
Play Clientbound 0x5F minecraft:set_equipment EntityEquipmentCodecs.SetEquipmentV1_16 read:256 shape:opaque
Expand All @@ -142,7 +142,7 @@ Play Clientbound 0x61 minecraft:set_health EntityStateCodecs.SetHealth read:9 sh
Play Clientbound 0x62 minecraft:set_held_slot EntityStateCodecs.SetHeldSlotV1_21_4 read:1 shape:opaque
Play Clientbound 0x63 minecraft:set_objective ScoreboardCodecs.SetObjectiveV1_21_5 fault:ComponentFormatException shape:opaque
Play Clientbound 0x64 minecraft:set_passengers EntityStateCodecs.SetPassengers read:2 shape:opaque
Play Clientbound 0x65 minecraft:set_player_inventory MakeSetPlayerInventory(Table770) read:2 shape:varint,stack|components/3e625a95
Play Clientbound 0x65 minecraft:set_player_inventory MakeSetPlayerInventory(Table770) read:2 shape:varint,stack|components/0995b74c
Play Clientbound 0x66 minecraft:set_player_team ScoreboardCodecs.SetPlayerTeamV1_21_5 fault:ComponentFormatException shape:set_player_team(V1_21_5)
Play Clientbound 0x67 minecraft:set_score ScoreboardCodecs.SetScoreV1_21_5 read:5 shape:opaque
Play Clientbound 0x68 minecraft:set_simulation_distance WorldStateCodecs.SetSimulationDistanceV1_18 read:1 shape:opaque
Expand All @@ -164,7 +164,7 @@ Play Clientbound 0x77 minecraft:test_instance_block_status marker n/a shape:opaq
Play Clientbound 0x78 minecraft:ticking_state marker n/a shape:opaque
Play Clientbound 0x79 minecraft:ticking_step marker n/a shape:opaque
Play Clientbound 0x7A minecraft:transfer PlayCommonCodecs.Transfer read:2 shape:string,varint
Play Clientbound 0x7B minecraft:update_advancements AdvancementCodecs.UpdateAdvancementsV1_21_5 read:5 shape:update_advancements(icon=countfirst/components/3e625a95,text=nbt/modern,criteria=0,telemetry=1,showadv=1)
Play Clientbound 0x7B minecraft:update_advancements AdvancementCodecs.UpdateAdvancementsV1_21_5 read:5 shape:update_advancements(icon=countfirst/components/0995b74c,text=nbt/modern,criteria=0,telemetry=1,showadv=1)
Play Clientbound 0x7C minecraft:update_attributes EntityEquipmentCodecs.UpdateAttributesV1_21 read:2 shape:opaque
Play Clientbound 0x7D minecraft:update_mob_effect EntityEffectCodecs.UpdateMobEffectV1_20_5 read:5 shape:opaque
Play Clientbound 0x7E minecraft:update_recipes RecipeCodecs.UpdateRecipesModern read:256 shape:opaque
Expand All @@ -188,7 +188,7 @@ Play Serverbound 0x0C minecraft:client_information PlayClientInformationCodecs.V
Play Serverbound 0x0D minecraft:command_suggestion CommandSuggestionCodecs.ServerCommandSuggestionV1_13 read:2 shape:opaque
Play Serverbound 0x0E minecraft:configuration_acknowledged ConfigurationCodecs.ConfigurationAcknowledged read:0 shape:opaque
Play Serverbound 0x0F minecraft:container_button_click ContainerCodecs.ContainerButtonClickModern read:2 shape:opaque
Play Serverbound 0x10 minecraft:container_click MakeContainerClick(Table770) read:8 shape:varint,varint,short,byte,varint,varint*(short,hashed_stack),hashed_stack|components/3e625a95
Play Serverbound 0x10 minecraft:container_click MakeContainerClick(Table770) read:8 shape:varint,varint,short,byte,varint,varint*(short,hashed_stack),hashed_stack|components/0995b74c
Play Serverbound 0x11 minecraft:container_close ContainerCodecs.ContainerCloseServerModern read:1 shape:opaque
Play Serverbound 0x12 minecraft:container_slot_state_changed ContainerCodecs.ContainerSlotStateChangedModern read:3 shape:opaque
Play Serverbound 0x13 minecraft:cookie_response PlayCommonCodecs.CookieResponse fault:FormatException shape:identifier,opt_bytes
Expand Down Expand Up @@ -226,7 +226,7 @@ Play Serverbound 0x32 minecraft:set_beacon marker n/a shape:opaque
Play Serverbound 0x33 minecraft:set_carried_item EntityServerboundCodecs.SetCarriedItem read:2 shape:opaque
Play Serverbound 0x34 minecraft:set_command_block WorldBlockCodecs.SetCommandBlockV1_14 read:11 shape:opaque
Play Serverbound 0x35 minecraft:set_command_minecart marker n/a shape:opaque
Play Serverbound 0x36 minecraft:set_creative_mode_slot MakeCreativeSlot(Table770) read:3 shape:short,delimited_stack|components/3e625a95
Play Serverbound 0x36 minecraft:set_creative_mode_slot MakeCreativeSlot(Table770) read:3 shape:short,delimited_stack|components/0995b74c
Play Serverbound 0x37 minecraft:set_jigsaw_block marker n/a shape:opaque
Play Serverbound 0x38 minecraft:set_structure_block marker n/a shape:opaque
Play Serverbound 0x39 minecraft:set_test_block marker n/a shape:opaque
Expand Down
Loading
Loading