refactor: use QuickProxyNet for proxy negotiation - #3
Merged
Merged
Conversation
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Replace UMPK's HTTP CONNECT, SOCKS4/SOCKS4a, and SOCKS5 handshake code with QuickProxyNet 3.0.0. The public proxy factories are unchanged. UMPK also overrides QuickProxyNet's abortive socket-close default so disposal still produces peer-observed EOF on macOS and other platforms.
The package version is now
0.9.0-beta.4.Fixes #1.
Scope
All supported protocols (47 through 777). Proxy setup sits below the version-specific protocol code.
Validation
The language-data check was not run because this worktree does not have the ignored
MinecraftOfficial/downloads/1.8.9/server.jarprerequisite.Notes for reviewers
There are no public API changes. QuickProxyNet accepts HTTP CONNECT status 200; the old code accepted any 2xx response.