ci: align release.yml action versions with sync-check#34
Merged
Conversation
Dependabot's github-actions group bumped sync-check.yml to actions/checkout@v7 and actions/setup-node@v6 (PR #15). release.yml was added after that config landed but before the bump reached it, so the two workflows pinned different major versions of the same two actions: sync-check.yml checkout@v7 setup-node@v6 release.yml checkout@v5 setup-node@v5 Nothing was broken -- v5 still runs -- but a repo that ships a supply-chain-security skill should not have two workflows disagreeing about which major version of an action they trust, and Dependabot's grouped weekly PR would have raised them separately and confusingly. Note release.yml only runs on a `v*` tag push, so this PR's CI does not exercise it. The evidence that v7/v6 work is sync-check.yml, which has been green on them since PR #15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot's
github-actionsgroup bumpedsync-check.yml(PR #15).release.ymlwas added afterdependabot.ymllanded but before that bump reached it, so the two workflows pinned different majors of the same two actions:Nothing was broken — v5 still runs. But a repo shipping a
supply-chain-securityskill should not have two workflows disagreeing about which major of an action they trust, and Dependabot's next grouped PR would have surfaced them as separate, confusing bumps.After
A caveat worth stating
release.ymlonly triggers on av*tag push, so this PR's CI does not exercise it. The evidence thatv7/v6work issync-check.yml, which has been green on them since PR #15 and uses the same two actions the same way. The next tag will be the first real run.Not changed, on purpose
release.ymlcallsgh release createwithout--latest=false, so GitHub marks the newest-created release as "Latest" rather than the highest version. That is correct for a normal release (you tag ascending) and only misbehaves when back-filling an old tag — which happened once, was corrected withgh release edit v0.15.0 --latest, and won't recur. Adding the flag would break the common case.Verification