695 max area of island#19
Open
MA-yo-TA wants to merge 2 commits into
Open
Conversation
jjysogfy
reviewed
Jun 28, 2026
|
|
||
| class Solution: | ||
| def maxAreaOfIsland(self, grid: list[list[NodeType]]) -> int: | ||
| num_rows = len(grid) |
There was a problem hiding this comment.
ただの感想ですが、こうして、変数の使用より宣言が先の行にあると見やすいです。
| def maxAreaOfIsland(self, grid: list[list[NodeType]]) -> int: | ||
| num_rows = len(grid) | ||
| num_columns = len(grid[0]) | ||
| seen_nodes: set[tuple[int, int]] = set() |
There was a problem hiding this comment.
単語nodeを変数名に使っていますが、個人的には、cell, position, coordinateあたりの単語のほうが見慣れていて、引っかかりを感じにくいです。
ノードと言われたときは、このコードはBFSをしていて、そのノードは(row, column)だ、と考える必要があるからだと思います。
Owner
Author
There was a problem hiding this comment.
ありがとうございます。おっしゃる通り cell とかの方がいいですね。
node はグラフ的な頭に引っ張られた命名になっちゃってますね。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
この問題：https://leetcode.com/problems/max-area-of-island/
次の問題：https://leetcode.com/problems/number-of-connected-components-in-an-undirected-graph/