Repository navigation
Set matslot on the subdiv shape of a shape chain - #1116
Merged
howetuft merged 1 commit intoNov 11, 2026
Merged
Conversation
howetuft
force-pushed
the
feature/subdiv-shared-envelope
branch
from
November 11, 2026 23:12
d3e5b19 to
22d1b13
Compare
…e per-submesh slot id in tri AOV layer 2 Ported from the feature branch onto current main (the rest of the branch was already merged via LuxCoreRender#1114/LuxCoreRender#1115): - set_matslot_on_subdiv_shape() walks a shape chain via the source links and sets matslot on the subdiv shape itself (the shape LuxCore reads matslot from), falling back to the final shape. - Each submesh (material x island group) gets a unique slot id (group index + 1; +1 because the wireframe texture reads tri AOV layer 2 and skips an edge class when the value is 0), written to the tri AOV and passed as matslot to the subdiv shape, so the C++ subdiv envelope resplits per submesh instead of merging all islands of one material. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
howetuft
force-pushed
the
feature/subdiv-shared-envelope
branch
from
November 11, 2026 23:20
22d1b13 to
740d8cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Walk the shape chain via source links and set matslot on the subdiv shape itself (LuxCore only reads matslot there), so subdiv-in-chain materials split per material and share the single envelope subdivision run.