dedup fallback - #1
Merged
Merged
Conversation
Hidden items aren't added to the map, which causes each parent path to re-enqueue the entire subtree. This led to exponential rustdoc hangs, as noted in issue rust-lang#160439.
The rmake.rs script now builds dep.rs and runs rustdoc with a 60-second kill watchdog, since compiletest doesn't have individual test timeouts. This allows regressions to fail quickly instead of causing CI to hang.
This includes a nested #[doc(hidden)] fan structure (B=8, D=12) in dep.rs, which is only reachable through hidden parents. The main.rs file implements dep::Tr to trigger the trait path rendering that caused the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang#160439. Hidden items never entered visible_parent_map, so each parent path re-enqueued its whole subtree, causing exponential rustdoc slowdowns. Regression introduced in nightly-2026-08-03 by rust-lang#159881. Hidden items are now tracked in a fallback_seen set, speeding the reproducer up ~460x (from a >60s hang to 0.13s). New tests in tests/run-make/rustdoc/visible-parent-map-hang.