screenshot: Log when prepareScreenshotData fails - #2712
Merged
charles-lunarg merged 1 commit intoJul 30, 2026
Merged
Conversation
|
CI VulkanTools build queued with queue ID 58777. |
|
CI VulkanTools build # 5347 running. |
|
CI VulkanTools build # 5347 passed. |
charles-lunarg
force-pushed
the
screenshot_warn_wrong_compat_class
branch
from
July 30, 2026 15:23
9986e43 to
f00bb20
Compare
|
CI VulkanTools build queued with queue ID 59384. |
|
CI VulkanTools build # 5350 running. |
This makes a silent return false into a loud one to let users know why screenshot failed. Found when running vkcube in wayland as the format chosen is a 64 bit pixel SFLOAT image.
charles-lunarg
force-pushed
the
screenshot_warn_wrong_compat_class
branch
from
July 30, 2026 15:26
f00bb20 to
b06d1a3
Compare
|
CI VulkanTools build queued with queue ID 59395. |
|
CI VulkanTools build # 5351 running. |
|
CI VulkanTools build # 5351 failed. |
|
CI VulkanTools build queued with queue ID 59698. |
|
CI VulkanTools build # 5352 running. |
|
CI VulkanTools build # 5352 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a silent return false into a loud one to let users know why screenshot failed. Found when running vkcube in wayland as the format chosen is a 64 bit pixel SFLOAT image.